Add int return typehints to protected test helper methods

Created on 2 July 2024, 2 months ago
Updated 3 September 2024, 4 days ago

Problem/Motivation

See 🌱 Add return typehints to protected test helper methods Active

Steps to reproduce

Add this to phpcs.xml.dist

<rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint">
  <include-pattern>*/tests/*</include-pattern>
</rule>

Run composer phpcbf

Grep the git diff output for changes that add : int to protected or private methods

Proposed resolution

Commit the changes identified in the steps to reproduce

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

RTBC

Version

11.0 🔥

Component
PHPUnit 

Last updated about 12 hours ago

Created by

🇦🇺Australia mstrelan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mstrelan
  • First commit to issue fork.
  • 🇪🇸Spain abarrio

    I made a part of the development.

  • Status changed to Needs work 2 months ago
  • 🇦🇺Australia mstrelan

    @abarrio thanks for working on this. The scope should be limited to tests only, so in paths like core/tests/* and core/*/*/tests. We also don't want to add union types in this issue, to keep the scope down, so should be limited to int returns only.

  • Merge request !9323Add int return to protected test methods → (Open) created by mstrelan
  • Status changed to Needs review 13 days ago
  • Pipeline finished with Failed
    13 days ago
    Total: 473s
    #264555
  • Pipeline finished with Success
    13 days ago
    Total: 1280s
    #264571
  • Pipeline finished with Failed
    13 days ago
    Total: 672s
    #264722
  • Pipeline finished with Success
    13 days ago
    Total: 658s
    #264763
  • Pipeline finished with Success
    12 days ago
    Total: 595s
    #265459
  • First commit to issue fork.
  • Pipeline finished with Failed
    11 days ago
    Total: 135s
    #266571
  • Status changed to Needs work 11 days ago
  • 🇺🇸United States smustgrave

    Not sure why cspell is showing up but pipeline failed.

  • Status changed to Needs review 10 days ago
  • 🇦🇺Australia mstrelan

    cspell was due to catch and I debugging some pipeline cache issues, let's move that to 🐛 Hardcode the core project ID for fetching artifacts from the gitlab API Needs review . Have reverted and rebased.

  • Pipeline finished with Success
    10 days ago
    Total: 897s
    #267557
  • Status changed to RTBC 4 days ago
  • 🇺🇸United States smustgrave

    Nice, in that case change seems fine.

Production build 0.71.5 2024