Add int return typehints to protected test helper methods

I made a part of the development.

@abarrio thanks for working on this. The scope should be limited to tests only, so in paths like core/tests/* and core/*/*/tests. We also don't want to add union types in this issue, to keep the scope down, so should be limited to int returns only.

Not sure why cspell is showing up but pipeline failed.

cspell was due to catch and I debugging some pipeline cache issues, let's move that to 🐛 Hardcode the core project ID for fetching artifacts from the gitlab API Needs review . Have reverted and rebased.

Nice, in that case change seems fine.

I applied the diff and tested.

My results show two methods that have not been changed

+  protected function getUnapprovedComment($subject): int {
+  protected function doEditStep($active_langcode, $default_revision, $untranslatable_update = FALSE, $valid = TRUE): int {

Thanks @quietone, I should have indicated why these were skipped. Both of these claim to return an int but actually return a string.

The two methods are:

\Drupal\Tests\comment\Functional\CommentTestBase::getUnapprovedComment
\Drupal\KernelTests\Core\Entity\EntityDecoupledTranslationRevisionsTest

I've added a note to fix these in the parent issue. Not opening individual issues for now so we can figure out appropriate scope for these little fixes.

Setting back to RTBC as there is nothing to change here.

@mstrelan, thanks for the explanation.

I reviewed the MR and I think it is ready for commit. There is JavaScript here, which I no little of. So I confirmed that transfersize returns an int. So, this is good to go.

Committed d433d96 and pushed to 11.x. Thanks!

I tried to find the commits made by @abarrio but wasn't able to. So, I DMed mstrelan who confirmed the contribution was valid, it just needed to be de-scoped. Therefor, adding credit.

This is causing test failures on HEAD, from \Drupal\migrate_drupal\Tests\StubTestTrait::createEntityStub. Although, I don't understand why tested passed in the lastest pipeline here though.

I investigated the fail mentioned in #18 and it was due to 📌 Enforce strict types in tests Fixed . This uncovered that sometimes ::createEntityStub returns an int and sometimes a string. I've added this one to the list of return types to be fixed in the parent issue. I've removed the return type from this method in the MR, setting back to NR.

Appears to have test failures.

Yes, but those are in tests that are not changed in the MR.

Rebase seems good and all green!

Thanks!

Assigning to myself to commit within 24 hours.

Thanks! Let's try this again.

Committed 2319f33 and pushed to 11.x. Thanks!

quietone → closed merge request !9323

Automatically closed - issue fixed for 2 weeks with no activity.