Add return typehints to protected test helper methods

Created on 18 June 2024, 7 months ago

Problem/Motivation

While reviewing 📌 Add void return typehints to all test methods Active , we noticed a number of protected helper methods that are not receiving return typehints as part of the scope of the issue.

Proposed resolution

  • Add return typehints to all protected helper methods, starting with those that return void. Needs child issue.
  • Add additional child issues as appropriate.
  • As a possible followup, also consider renaming those that are named testSomethingSomething() to a less-confusing naming pattern, like the more common assertSomethingSomething() (since they aren't actually test methods, just helpers).

Remaining tasks

TBD

API changes

Protected test helper methods get return typehints.

Release notes snippet

TBD

🌱 Plan
Status

Active

Version

11.0 🔥

Component
PHPUnit 

Last updated about 14 hours ago

Created by

🇺🇸United States xjm

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024