Thanks for looking into it guys!
I addressed all of the PHPCS warnings and observations, and release 1.0.1 version. Please review
thebumik → created an issue.
Applied necessary changes to fix these tests.
thebumik → made their first commit to this issue’s fork.
Added necessary changes to fix that test.
thebumik → made their first commit to this issue’s fork.
MR comments were addressed.
Addressed the comments from PR.
Applied required changes. Should be fine now.
thebumik → made their first commit to this issue’s fork.
thebumik → created an issue.
Fixed path tests. Please review
thebumik → made their first commit to this issue’s fork.
Fixed test, and removed deprecations.
thebumik → made their first commit to this issue’s fork.
Would greatly appreciate it if someone could review my pull request for this. Any feedback would be invaluable!
thebumik → made their first commit to this issue’s fork.
Would greatly appreciate it if someone could review my pull request for this. Any feedback would be invaluable!
Would greatly appreciate it if someone could review my pull request for this. Any feedback would be invaluable!
thebumik → made their first commit to this issue’s fork.
thebumik → changed the visibility of the branch 3439829-fix-blocks-tests to hidden.
thebumik → made their first commit to this issue’s fork.
Looks good to me, installed and tested it locally (no issues so far).
Please have @nod_ double-check as well.
thebumik → made their first commit to this issue’s fork.
Replaced jQuery val() methods with VanillaJS.
Please review!
Seems like a duplicate for this issue which is postponed. https://www.drupal.org/project/navigation/issues/3402907 📌 Parent menu items with URLs are not linked to, do we make these available? Closed: outdated
Implemented a solution to verify the presence of a URL for the parent menu item and ensured that the link maintains consistent styling. Nevertheless, this introduced a new challenge. In cases where a parent item has both a link and toolbar-popover functionality, it's necessary to ensure that the dropdown functionality is triggered only when clicking on the arrow icon, not the entire link. Addressing this issue will necessitate additional adjustments to the JS/CSS adjustments.
Hey all,
I noticed that behavior as well, I will be taking ownership of this feature to resolve the issue at hand.
Added the "revert to default" operation so users now can reset their navigation layout to the default configuration provided by the navigation module.
In developing this feature, I ensured careful consideration was given to the user experience and communication aspects. Users will be clearly informed about the implications of reverting to the default layout, including what changes will be lost. This addition aims to provide users with more control and flexibility while minimizing the risk of unintended modifications.
Overall, I believe this enhancement will greatly improve the usability and manageability of navigation settings.
I'll be taking ownership of this ticket and will work on resolving it as soon as possible.
I'll be taking ownership of this ticket and will work on resolving it as soon as possible.
thebumik → made their first commit to this issue’s fork.
thebumik → made their first commit to this issue’s fork.
thebumik → made their first commit to this issue’s fork.
SKAUGHT → credited thebumik → .
thebumik → created an issue.
thebumik → created an issue.