Contrib.social

Fix Layout Builder tests that rely on UID1's super user behavior

Open on Drupal.org →
Created on 10 April 2024, 9 months ago
Updated 25 April 2024, 8 months ago

Problem/Motivation

In 📌 Add a container parameter that can remove the special behavior of UID#1 Fixed an approach was taken where we can simply flag tests that are failing if we turn off user 1's super user powers, so that they can be taken care of in a followup. This issue is to collect all of these followups.

The goal is to have no tests in Drupal core that rely on UID1's special privileges so that we:

  1. Know these tests are correctly assigning the necessary permissions to run
  2. Can turn off the super user access policy in D11, knowing it won't break core
  3. Can remove the super user access policy in D12, providing an admin account recovery tool to replace it

Steps to reproduce

Go into any of the tests flagged with:

  /**
   * {@inheritdoc}
   *
   * @todo Remove and fix test to not rely on super user.
   * @see https://www.drupal.org/project/drupal/issues/3437620
   */

And:

  1. Remove the code below that sets the usesSuperUserAccessPolicy to TRUE.
  2. Run the test to see which test methods are failing

Proposed resolution

Assign the right permissions to make the test go green without the super user access policy. Those few tests that specifically test said policy can obviously stay, but will be removed along with the policy in D12.

Remaining tasks

  1. core/modules/layout_builder/tests/src/
    • Functional/LayoutBuilderOverridesTest.php
📌 Task
Status

Fixed

Version

10.3 ✨

Component
Layout builder  →

Last updated 2 days ago

Created by

🇬🇷Greece vensires

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @vensires
  • First commit to issue fork.
  • Merge request !7425Issue #3439893: Fix layout builder tests → (Open) created by thebumik
  • Status changed to Needs review 9 months ago
  • Comment 9 months ago →
    🇲🇩Moldova thebumik

    Would greatly appreciate it if someone could review my pull request for this. Any feedback would be invaluable!

  • Pipeline finished with Success
    9 months ago
    Total: 964s
    #143088
  • Status changed to Needs work 9 months ago
  • Comment 9 months ago →
    🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
        1)
    Drupal\Tests\file\Functional\DownloadTest::testPrivateFileTransferWithoutPageCache
    Correctly denied access to a file when file_test sets the header to -1.
    Failed asserting that 200 is identical to 403.
    
    /builds/issue/drupal-3439893/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
    /builds/issue/drupal-3439893/vendor/phpunit/phpunit/src/Framework/Constraint/IsIdentical.php:79
    /builds/issue/drupal-3439893/core/modules/file/tests/src/Functional/DownloadTest.php:138
    /builds/issue/drupal-3439893/core/modules/file/tests/src/Functional/DownloadTest.php:76
    /builds/issue/drupal-3439893/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
  • Comment 9 months ago →
    🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium

    Not sure how that one is related to the code here, though. Double-checking.

  • Pipeline finished with Success
    9 months ago
    Total: 4797s
    #143583
  • Status changed to RTBC 9 months ago
  • Comment 9 months ago →
    🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium

    Okay so it was a random test failure. RTBC then, but keeping an eye on this random failure.

  • Status changed to Fixed 8 months ago
  • Comment 8 months ago →
    🇬🇧United Kingdom alexpott 🇪🇺🌍

    Committed and pushed 0b3e6f1aaa to 11.x and 4b1e7c9e43 to 10.3.x. Thanks!

  • Comment 8 months ago →
    System Message
    • alexpott → committed c3cac16e on 10.3.x 
      Issue #3439893 by thebumik, vensires: Fix Layout Builder tests that rely...
  • Comment 8 months ago →
    System Message
    • alexpott → committed fbe64244 on 11.x 
      Issue #3439893 by thebumik, vensires: Fix Layout Builder tests that rely...
  • Comment 8 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024