- Merge request !73903259381: Follow up jquery val() replace with VanillaJS โ (Open) created by thebumik
- Status changed to Needs review
3 months ago 1:44pm 9 April 2024 - ๐ฒ๐ฉMoldova thebumik
Replaced jQuery val() methods with VanillaJS.
Please review! - Status changed to Needs work
3 months ago 2:11pm 9 April 2024 The Needs Review Queue Bot โ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- ๐ซ๐ทFrance nod_ Lille
I think you reverted a bit too much code in jquery.form.js, we still need to remove the calls to .val() maybe I wasn't clear, sorry.
- ๐ซ๐ทFrance nod_ Lille
Had a closer look. Couple of things:
- Let's drop the changes to
filter.filter_html.admin.js
: The whole thing is deprecated and will be removed in D11. ๐ Deprecate core/modules/editor/js/editor.admin.js JS APIs in Drupal 10, for removal in Drupal 11 Fixed - In the same spirit, since
jquery.form.js
is excluded from eslint, let's remove changes to this one as well. It's a temporary fork until we get rid of it and this one require jQuery to work at all so no sense in removing the dependency on it. - The states test failure is legit, we do not support select with multiple values, jQuery return an array with all the selected options, .value only return the first value. We need to work around that somehow.
Sorry for making you add/remove changes to specific files, I changed my mind after spending a bit more time with the code.
- Let's drop the changes to
- ๐ฎ๐ณIndia yash.rode pune
yash.rode โ made their first commit to this issueโs fork.
- First commit to issue fork.
- Issue was unassigned.
- Status changed to Needs review
29 days ago 6:37am 30 May 2024 The test are fixed now.In response to
Let's drop the changes to filter.filter_html.admin.js: The whole thing is deprecated and will be removed in D11. #2567801: Deprecate core/modules/editor/js/editor.admin.js JS APIs in Drupal 10, for removal in Drupal 11
06c9630b
commit removes the whole file but as far as i understood from the comment is that we just wanted to revert the changes from that file.It would be helpful if @nod_ can verify the change.
Marking it needs review as rest everything is addressed apart from the changes in 06c9630b commit.- ๐บ๐ธUnited States smustgrave
smustgrave โ changed the visibility of the branch 3259381-follow-up-for-jquery to hidden.
- Status changed to RTBC
8 days ago 12:20am 20 June 2024 - ๐บ๐ธUnited States smustgrave
Still not a huge fan of [0]. personally but it was used in the previous commit so would assume fine here.