- Issue created by @vensires
- First commit to issue fork.
- Status changed to Needs review
8 months ago 5:10pm 10 April 2024 - Status changed to Needs work
8 months ago 5:47pm 10 April 2024 The Needs Review Queue Bot โ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- ๐ง๐ชBelgium kristiaanvandeneynde Antwerp, Belgium
There were 2 errors: 1) Drupal\Tests\path\Functional\PathContentModerationTest::testNodePathAlias Behat\Mink\Exception\ElementNotFoundException: Form field with id|name|label|value "path[0][alias]" not found. /builds/issue/drupal-3439904/vendor/behat/mink/src/WebAssert.php:731 /builds/issue/drupal-3439904/vendor/behat/mink/src/WebAssert.php:768 /builds/issue/drupal-3439904/core/tests/Drupal/Tests/WebAssert.php:968 /builds/issue/drupal-3439904/core/modules/path/tests/src/Functional/PathContentModerationTest.php:111 /builds/issue/drupal-3439904/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 2) Drupal\Tests\path\Functional\PathContentModerationTest::testTranslatedModeratedNodeAlias Behat\Mink\Exception\ElementNotFoundException: Button with id|name|label|value "Save (this translation)" not found. /builds/issue/drupal-3439904/core/tests/Drupal/Tests/WebAssert.php:151 /builds/issue/drupal-3439904/core/tests/Drupal/Tests/UiHelperTrait.php:78 /builds/issue/drupal-3439904/core/modules/path/tests/src/Functional/PathContentModerationTest.php:207 /builds/issue/drupal-3439904/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
- Status changed to Needs review
8 months ago 10:09am 11 April 2024 - ๐ง๐ชBelgium kristiaanvandeneynde Antwerp, Belgium
Left a comment, not sure if we want to switch from relying on UID1 to relying on being able to bypass all node permissions. The goal is that our tests prove that whoever has the right permissions (without super user stuff), can use the website as intended for their role.
- Status changed to Needs work
8 months ago 1:55pm 11 April 2024 - ๐บ๐ธUnited States smustgrave
Left a comment but not sure we need all those modules installed for this test
- Status changed to Needs review
8 months ago 2:48pm 11 April 2024 - Status changed to RTBC
8 months ago 4:08pm 11 April 2024 - ๐บ๐ธUnited States smustgrave
Reviewed the permissions and believe those should be fine, didn't seem to have a crazy one to me.
- Status changed to Needs work
8 months ago 8:55pm 11 April 2024 - Status changed to Needs review
8 months ago 8:31am 12 April 2024 - Status changed to RTBC
8 months ago 1:39pm 12 April 2024 - Status changed to Needs work
8 months ago 9:42am 13 April 2024 - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
Added a couple of comments to the MR. There's no need to add permissions as a class property to the test.
- ๐ฎ๐ณIndia pradhumanjainOSL
pradhumanjain2311 โ made their first commit to this issueโs fork.
- Status changed to Needs review
8 months ago 1:28pm 15 April 2024 - Status changed to RTBC
8 months ago 2:15pm 15 April 2024 - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
Committed and pushed eeb7e60c30 to 11.x and 7e4ccefc08 to 10.3.x. Thanks!
-
alexpott โ
committed 7e4ccefc on 10.3.x
Issue #3439904 by thebumik, pradhumanjain2311, smustgrave,...
-
alexpott โ
committed 7e4ccefc on 10.3.x
- Status changed to Fixed
8 months ago 10:35pm 15 April 2024 -
alexpott โ
committed eeb7e60c on 11.x
Issue #3439904 by thebumik, pradhumanjain2311, smustgrave,...
-
alexpott โ
committed eeb7e60c on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.