In MenuForm, the "add link" link should only be provided if MenuLinkContentAccessControlHandler->createAccess() is true

Created on 4 October 2023, over 1 year ago

Updated 7 March 2024, about 1 year ago

Problem/Motivation

When we go to the form for an empty menu without links, there's a message in the link table that says There are no menu links yet. <a href="add-link-url">Add Link</a>.

If we are using core without any contrib/custom, That "Add Link" link is not really a concern. But! It is not unheard of to restrict the ability to create menu links, while it still being able to access the menu form. Fortunately, it should be fairly easy to add a condition to determine if it is appropriate to provide this link

Doing this without dependency injection might look something like

$menu_link_access_handler = \Drupal::entityTypeManager()->getAccessControlHandler('menu_link_content')

if ($menu_link_access_handler->createAccess()) {
    $form['links']['#empty'] = $this->t('There are no menu links yet. <a href=":url">Add link</a>.', [
      ':url' => Url::fromRoute('entity.menu.add_link_form', ['menu' => $this->entity->id()], [
        'query' => ['destination' => $this->entity->toUrl('edit-form')->toString()],
      ])->toString(),
    ]);
} 
else {
    $form['links']['links']['#empty'] = t('There are no menu links yet.');

}

But the actual fix should inject the access handler.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task

Status

Needs work

Version

11.0 🔥

Component

Menu system →

Last updated 2 days ago

Maintained by
🇩🇪Germany @dawehner
🇺🇸United States @pwolanin

Created by

🇺🇸United States bnjmnm Ann Arbor, MI

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Merge Requests

!6943In MenuForm, the "add link" link should only be provided if MenuLinkContentAccessControlHandler->createAccess() is true
Open
🇲🇩Moldova thebumik
updated about 1 year ago

Comments & Activities

Issue created by @bnjmnm
First commit to issue fork.
Merge request !6943Issue #339173: Adding access handler check allowing to create new menu link → (Open) created by thebumik
Status changed to Needs review about 1 year ago7:18pm 6 March 2024
Comment about 1 year ago →
🇲🇩Moldova thebumik
Pipeline finished with Success
about 1 year ago
Total: 662s
#113176
Status changed to Needs work about 1 year ago2:49am 7 March 2024
Comment about 1 year ago →
🇺🇸United States smustgrave
Very surprised this didn’t break anything. Guess we didn’t have test coverage for it before. Think we should add a small test or expand on one for this change.

Thanks!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024