When we go to the form for an empty menu without links, there's a message in the link table that says There are no menu links yet. <a href="add-link-url">Add Link</a>.
If we are using core without any contrib/custom, That "Add Link" link is not really a concern. But! It is not unheard of to restrict the ability to create menu links, while it still being able to access the menu form. Fortunately, it should be fairly easy to add a condition to determine if it is appropriate to provide this link
Doing this without dependency injection might look something like
$menu_link_access_handler = \Drupal::entityTypeManager()->getAccessControlHandler('menu_link_content')
if ($menu_link_access_handler->createAccess()) {
$form['links']['#empty'] = $this->t('There are no menu links yet. <a href=":url">Add link</a>.', [
':url' => Url::fromRoute('entity.menu.add_link_form', ['menu' => $this->entity->id()], [
'query' => ['destination' => $this->entity->toUrl('edit-form')->toString()],
])->toString(),
]);
}
else {
$form['links']['links']['#empty'] = t('There are no menu links yet.');
}
But the actual fix should inject the access handler.
Needs work
11.0 🔥
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Very surprised this didn’t break anything. Guess we didn’t have test coverage for it before. Think we should add a small test or expand on one for this change.
Thanks!