Fix Comments tests that rely on UID1's super user behavior

Would greatly appreciate it if someone could review my pull request for this. Any feedback would be invaluable!

Webuser2 has a duplicate permission, can you clean that up please?

Small nitpick: I would keep the order of the user properties like it was. Now you have $webUser2 first with a comment calling it "a secondary user" before you even configured your primary user. It's a bit confusing in this order.

Suggestion: $adminUser above $webUser2.

Seems feedback has been addressed and think these permissions should be good

Left a minor comment on the MR, fine to self RTBC once fixed

Applied required changes. Should be fine now.

I've added some comments to the MR... I don't think we should be overwriting the adminUser with a new user.

pradhumanjain2311 → made their first commit to this issue’s fork.

MR comments were addressed.

Not a huge fan of "more_admin_role" but it's a test so not a big deal to me.

Committed and pushed 2b0321c170 to 11.x and d35edb34b2 to 10.3.x. Thanks!

Made the following changes on commit

diff --git a/core/modules/comment/tests/src/Functional/CommentStatisticsTest.php b/core/modules/comment/tests/src/Functional/CommentStatisticsTest.php
index a8d5909e68..9a309f16e0 100644
--- a/core/modules/comment/tests/src/Functional/CommentStatisticsTest.php
+++ b/core/modules/comment/tests/src/Functional/CommentStatisticsTest.php
@@ -7,7 +7,6 @@
 use Drupal\comment\CommentInterface;
 use Drupal\comment\CommentManagerInterface;
 use Drupal\comment\Entity\Comment;
-use Drupal\user\UserInterface;
 
 /**
  * Tests comment statistics on nodes.
@@ -21,7 +20,7 @@ class CommentStatisticsTest extends CommentTestBase {
    *
    * @var \Drupal\user\UserInterface
    */
-  protected UserInterface $webUser2;
+  protected $webUser2;
 
   /**
    * {@inheritdoc}
@@ -35,12 +34,11 @@ protected function setUp(): void {
     parent::setUp();
 
     // Add more permissions the admin user.
-    $more_admin_role = $this->drupalCreateRole([
+    $this->adminUser->addRole($this->drupalCreateRole([
       'administer permissions',
       'access administration pages',
       'administer site configuration',
-    ]);
-    $this->adminUser->addRole($more_admin_role)->save();
+    ]))->save();
     // Create a second user to post comments.
     $this->webUser2 = $this->drupalCreateUser([
       'post comments',

Removed the unnecessary variable and reverted out of scope changes.

Automatically closed - issue fixed for 2 weeks with no activity.