This issue can be closed - I found this to be a project specific problem after further testing.
minirobot β created an issue.
minirobot β created an issue.
minirobot β created an issue.
marcoscano β credited minirobot β .
minirobot β created an issue.
Tidied up patch #35 to improve the conditional statement.
minirobot β created an issue.
minirobot β created an issue.
Review/Testing instructions for the merge request:
1. Configure allowed hosts at /admin/config/media/tableau.
2. Create a Tableau media item with the embed hosted at one of the allowed hosts entered above.
3. Test with both self and publicly (https://public.tableau.com) hosted domains.
minirobot β changed the visibility of the branch 3447283-add-support-for to hidden.
minirobot β created an issue.
Yay thank you!
There is a core issue related to multiple value field validation: https://www.drupal.org/project/drupal/issues/3344082 π Improve required validation of multiple value fields Active . Only the first item is validated rather than the field as a whole.
I propose that we do not make the first set of fields removable until this is fixed. I've updated the merge request and tests.
minirobot β created an issue.
1- Add support for CKEditor5 textareas
2- Adjust the theming in Seven.
I added ckeditor 5 support based on @penyaskito's notes.
It looks like the remove button alignment was fixed by @penyaskito already.
minirobot β made their first commit to this issueβs fork.
Updated the patch to add the "path" text change.
Adding a patch.
minirobot β created an issue.
minirobot β created an issue.
Adding a patch.
Testing steps
- Install and enable the Override Node Options module
- Set permissions provided by the Override Node Options module such as
Override [content type] authored by option
oroverride all authored by option
. - Attempt to change the author of several nodes to verify it is working.
- Test also with disabled permissions and verify.
minirobot β created an issue.
Thanks for your review @nikral. I've made the suggested changes in the 1.0.x branch.
This method is static, but you call it with $this
$pattern = $this->getUrlRegexPattern();
You can also call it with self:: but I don't know what is the best practice
I used self::getUrlRegexPattern()
as you suggested. Since getUrlRegexPattern
is a static member self
is correct.
minirobot β created an issue.
Adding a patch.
minirobot β created an issue.
Implemented the suggestions from #20:
- Moved the schema update into the post update hook.
- Removed setRedirectDynamic and restored the functions it replaced.
Fixed wrong patch posted in comment #18.
Adding an update hook to resolve the entity mismatch error on the rid field.
Updating patch to fix coding standards.
Updated patch to fix tests.
Removing the code that uses the lightning_scheduler.migrator service from the previous patch.
I could not get patch #11 to apply without errors so I created a new patch. I also added a post update hook to address the issue mentioned in comment #24.
Adding a patch.
minirobot β created an issue.
Adding a patch.
minirobot β created an issue.
Adding a patch with a proposed solution.
minirobot β created an issue.
There is also this issue in the webp issue queue, which is about adding the original extension to the URLs and therefore fix the issue:
π Rendering duplicate images when the original images have the same name but different extension RTBC
When using the webp patch, I had to make a minor change in stage file proxy to include the query parameters in the request. I found that the image token parameter ?itok
was needed in the request for the image.
I'm attaching the change I made as a patch.