- Issue created by @minirobot
- Status changed to Needs review
over 1 year ago 3:03pm 31 August 2023 - last update
over 1 year ago 82 pass, 1 fail - 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
Setting as needs review so tests are run.
The last submitted patch, 3: 3383865-2.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs work
over 1 year ago 3:34pm 31 August 2023 - 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
Test failure is legit and expected. We would need to adapt the test.
- last update
about 1 year ago 82 pass, 1 fail - @penyaskito opened merge request.
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
A BC layer was added in https://www.drupal.org/project/linkit/issues/3354873 🐛 Direct URL to media file entity does not work because relative URL does not pass URL path validation Fixed , but this broke if using the newer APIs. I covered that in the PR, which includes the patch at #3 as the starting point.
- last update
about 1 year ago 83 pass - Status changed to Needs review
about 1 year ago 12:31am 8 November 2023 - 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
The failure was because we had:
// For media entities, check if standalone URLs are allowed. If not, then // strip '/edit' from the end of the canonical URL returned // by $entity->toUrl().
If standalone URLs are not allowed, I don't think we should be showing an url that would be a 404. So we actually should show the edit form, which is the canonical url in that case.