- Issue created by @minirobot
- Merge request !11Do not append items to the end after removing the field items. → (Merged) created by minirobot
- last update
9 months ago 4 pass, 1 fail - Status changed to Needs review
9 months ago 12:49pm 23 April 2024 - last update
9 months ago 5 pass - last update
9 months ago 5 pass - 🇬🇧United Kingdom minirobot London
There is a core issue related to multiple value field validation: https://www.drupal.org/project/drupal/issues/3344082 🐛 Improve required validation of multiple value fields Active . Only the first item is validated rather than the field as a whole.
I propose that we do not make the first set of fields removable until this is fixed. I've updated the merge request and tests.
- Status changed to RTBC
9 months ago 7:49am 30 April 2024 - 🇪🇸Spain marcoscano Barcelona, Spain
Thanks for working on this! I have not tested it myself, but I agree keeping it simple and adding the remove button only for widgets with more than one element makes sense.
RTBC to me, will wait a little bit in case @penyaskito has something additional to add since he reviewed the previous approach, but I'm 👍 to move forward with this.
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
👍 I wasn't sure I understood the problem, but @minirobot was patient with me and we huddled about it. Let's get this in :-D
- last update
9 months ago 5 pass -
marcoscano →
committed e01d5700 on 1.0.x authored by
minirobot →
Issue #3442879 by minirobot, marcoscano, penyaskito: Required field...
-
marcoscano →
committed e01d5700 on 1.0.x authored by
minirobot →
- Status changed to Fixed
9 months ago 7:40pm 1 May 2024 - 🇪🇸Spain marcoscano Barcelona, Spain
Thank you both! 🙏
Committed and tagged https://www.drupal.org/project/sam/releases/1.2.1 → Automatically closed - issue fixed for 2 weeks with no activity.