Allow to remove field items with a button

Found an issue, the button is not showing when we are already at the limit of items (e.g. cardinality 3 and I have 3 items).

We just needed to process everything no matter if all items were not empty.

Fixed another bug when we remove the last item, we want to show the button and the number of pending items again.

First of all, I am 👍 to include this, thanks! (I too have been asked by editors "how do I empty an existing value?" :) )

I left a minor comment in the MR, doesn't look like we need too many changes IMO.

However, in testing this on Tugboat, I see a couple things we probably want to address:

1) In testing with the seven admin theme, the button displays uncentered:

would it be worth adding a little bit of CSS to try to make this look good(-ish) in all admin themes?

2) (the error appeared when revealing a bunch of values and then removing some of them), but now I can't reproduce it... 🤯 I need to go for now but I'll come back and try to reproduce it again.

Maybe we can add a few assertions to https://git.drupalcode.org/project/sam/-/blob/1.0.x/tests/src/Functional... to add test coverage for the new feature? That would be great.

Thanks!

Thanks for the feedback!

Definitely needs tests. I've been seeing weird looping issues in our playwright tests, but that might be an issue on the tests or playwright itself.

I think this is ready now. Needs tests though.

Added tests.

1) In testing with the seven admin theme, the button displays uncentered:

Drupal 9 is end of life while this issue was fixed, so not sure if still a requirement? Being fair I only tested with Claro.

Thanks for working on this! (and apologies for the delay in reviewing it)

I think this is very close. To me the only remaining issues are:

1- Add support for CKEditor5 textareas
2- Adjust the theming in Seven. (I know D10 no longer includes it, but there are a lot of D10 sites still using it in the contrib namespace, it would be uncool to break those sites... :) )

Thanks!

1- Add support for CKEditor5 textareas
2- Adjust the theming in Seven.

I added ckeditor 5 support based on @penyaskito's notes.
It looks like the remove button alignment was fixed by @penyaskito already.

I even forgot that I added tests, thought those were still needed!
I've no strong feelings about ckeditor explicit coverage.
Will defer on Marcos if those are requested. If he doesn't require them this LGTM.

Great work @penyaskito and @minirobot! I don't believe we need extra tests for now.
Merged and tagged 1.2.0 → with it.
Thanks! 🎉

Automatically closed - issue fixed for 2 weeks with no activity.