Convert Redirect entity to revisionable

Adding an update hook to resolve the entity mismatch error on the rid field.

Fixed wrong patch posted in comment #18.

I'd like to see what tests say, marking NR.

1. +++ b/redirect.install
   @@ -236,3 +236,29 @@ function redirect_update_8109() {
   +function redirect_update_8110() {
   
   +++ b/redirect.post_update.php
   @@ -0,0 +1,124 @@
   + * Add the redirect revision table.
   

   Should this be moved to redirect_post_update_make_redirect_revisionable?

2. +++ b/src/Entity/Redirect.php
   @@ -95,26 +113,6 @@ class Redirect extends ContentEntityBase {
   -  public function setLanguage($language) {
   ...
   -  public function setStatusCode($status_code) {
   

   I don't see why deleting these functions and adding the setDynamic. Aside of this breaking APIs, it just doesn't make sense to me.

The last submitted patch, 14: 3313540-14.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 15: 3313540-15.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 16: 3313540-16.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 19: 3313540-19.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Implemented the suggestions from #20:

• Moved the schema update into the post update hook.
• Removed setRedirectDynamic and restored the functions it replaced.

I'm not convinced about this. I understand that a few people have this use case, but I maintain sites with tens and hundreds of thousands of redirects, and this update would be very expensive for them, result in extra storage and it's not useful for 99% of the sites.

This seems non-intrusive enough that it could be done in a separate project for those that require it, by replacing the entity class and hooks.

@berdir, revision (and publishing status) support is also needed by Workspaces, because at the moment we only have the "ignore" approach from 📌 Allow CRUD operations for Redirect entities in a workspace Needs review , which basically means that any redirect created in a workspace is also available in Live, and that's not really a great (nor expected) behavior :)

For your concern about extra storage, I think we shouldn't create new revisions by default like the latest patch does, but allow this behavior to be configured for people that need it.