Contrib.social

Automated Drupal 11 compatibility fixes for webform

Open on Drupal.org →
Created on 28 July 2024, 3 months ago
Updated 12 August 2024, 2 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Active

Version

6.3

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Project Update Bot
  • Comment 3 months ago →
    Project Update Bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

    Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-235699

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.4
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.3
  • Merge request !494Automated Project Update Bot fixes → (Merged) created by Project Update Bot
  • Status changed to Needs review 3 months ago
  • Pipeline finished with Failed
    3 months ago
    Total: 1934s
    #236461
  • Pipeline finished with Failed
    3 months ago
    Total: 2036s
    #236513
  • Status changed to Active 3 months ago
  • Comment 3 months ago →
    🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

    Merge request merged.

    Leaving open for more patches.

  • Comment 3 months ago →
    🇭🇺Hungary nagy.balint

    Sorry that it is only a patch file,
    but the update bot missed the version requirement.

    And of course php 8.3 is now the minimum.

  • Comment 3 months ago →
    🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

    This issue is only for automated patches.

    I will not be adding Drupal 11 to core_version_requirement until tests pass on that version.

    Even when this is compatible with Drupal 11, Webform itself will not require PHP 8.3 since people will still be running Webform on Drupal 10 with older PHP.

  • Comment 3 months ago →
    🇭🇺Hungary nagy.balint

    Yes, sorry about the php version change.

    I was just doing some test on my module on Drupal 11 which uses Webform, and I thought I share the diff.

    I did not encounter any issues in my short testing though which is good.

  • Comment 2 months ago →
    🇦🇺Australia VladimirAus Brisbane, Australia

    VladimirAus → changed the visibility of the branch 3464277-automated-drupal-11 to hidden.

  • Merge request !500Drupal 11 compatibility. → (Closed) created by VladimirAus
  • Pipeline finished with Failed
    2 months ago
    Total: 487s
    #243470
  • Comment 2 months ago →
    System Message
  • Comment 2 months ago →
    🇦🇺Australia VladimirAus Brisbane, Australia

    Not according to the other repositories but OK. 😂
    You might as well know when support for Drupal 11 is out, because this is exactly what this merge issue should be. 🤷

  • Comment 2 months ago →
    🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin

    This is confusing. How many compatibility fix issues do we have for webform now? Why we do not use one. How can users now know which they should apply for testing?

    Even when this is compatible with Drupal 11, Webform itself will not require PHP 8.3 since people will still be running Webform on Drupal 10 with older PHP.

    Is this causing the multiple core 11 fix issue confusion? That's what different release versions and branches are for. Why not creating another branch for webform PHP 8.3? It is strongly recommended for Drupal core 11 and higher and other contrib will follow.

  • Comment 2 months ago →
    🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

    Webform 6.3.x is to be compatible with Drupal 11 and PHP 8.3. It will not require PHP 8.3; it's minimum will be Drupal 10.3 and PHP 8.1.x. The current focus is getting tests to pass in 📌 Fix test failures Active .

  • Comment 2 months ago →
    🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin

    compatible with Drupal 11 and PHP 8.3. It will not require PHP 8.3
    Sure. Cross compatible php 8.2/8.3 to make users able to use 6.3 under Drupal 11 with php 8.3 → and Drupal 10 with php 8.3 or 8.2.

    Webform 6.2.x (for Drupal 10.1.x+) is the same as Webform 6.1.x with deprecated code removed and only for Drupal 10.1.x+. PHP 8.1+ required. This branch will receive security support until the Drupal 10.2 EOL.

    Jesus! Why I haven't seen that this issue 📌 Automated Drupal 11 compatibility fixes for webform Needs work is already closed since 2 weeks *facepalm*...

    Sorry for the noise, Liam. Nightshift eye syndrom. That was it all about what I wanted to care for.

  • Pipeline finished with Success
    25 days ago
    Total: 200s
    #290384
  • Comment 22 days ago →
    🇮🇳India ankitv18

    ankitv18 → changed the visibility of the branch 3464277-automated-drupal-11 to active.

  • Merge request !518Resolve #3464277 "Automated drupal 11" → (Open) created by ankitv18
  • Comment 22 days ago →
    🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

    This issue is only for automated patches.

  • Pipeline finished with Canceled
    22 days ago
    Total: 149s
    #293443
  • Pipeline finished with Canceled
    22 days ago
    Total: 204s
    #293447
  • Comment 22 days ago →
    🇮🇳India ankitv18

    It's been 2 months since last changes and D11 already rolled out. Also I'm not seeing any projectBot patches suggestion.
    So it would be great if webform get's D11 compatible as it is widely used in the drupal world.

  • Pipeline finished with Failed
    22 days ago
    Total: 1932s
    #293453
  • Comment 22 days ago →
    🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

    I agree. Work is underway in ✨ Drupal 11 compatibility fixes for webform Needs work .

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024