Claro theme loses actions for the view bulk operations form

I have added simple code that will move additional action buttons before the actions array are deleted from the form.

FYI: The changes are compatible with the Drupal 10.2.5

Question is this reproducible in just core and only with the contrib?

Believe we will need a test case to show the issue.

This can be reproduced without contrib, but will require a simple test module that form_alters the views bulk operations form and adds an additional item to $form['actions']. In HEAD, you can confirm the reported bug is occuring as that new item will not appear in the views bulk form. The solution is for Claro to still unset $form["actions"]["submit"] but anything else in $form["actions"] should get moved to $form['bulk_actions_container']

Added a test module that alters the form and also added test that verifies that the issue exists and also covering the solution.

Can this get a test-only branch or patch to confirm it fails without the fix? Be sure to customize drupalci → so it runs only this newly added test and not the full 30 minutes of Drupal core tests.

Left some comments

But tests appear to be passing when assuming they should be failing correct/

But tests appear to be passing when assuming they should be failing correct/

@smustgrave if you look at the tests,it asserts that the button is not present.As Ben mention in #9 🐛 Claro theme loses actions for the view bulk operations form Needs review that we only want a test to confirm that the issue exist but not the fix(alteast latest till #9).

Utkarsh_33 → changed the visibility of the branch 3447611-claro-theme-loses-test-only to hidden.

Utkarsh_33 → changed the visibility of the branch 3447611-claro-theme-loses-test-only to active.

Right so I would of expected the test only branch to fail and show the bug

smustgrave → changed the visibility of the branch 3447611-claro-theme-loses-test-only to hidden.

1) Drupal\FunctionalJavascriptTests\Theme\ClaroViewsBulkOperationsTest::testViewBulkOperationAlter
Behat\Mink\Exception\ElementNotFoundException: Button with id|name|label|value "Custom button" not found.
/builds/issue/drupal-3447611/core/tests/Drupal/Tests/WebAssert.php:158
/builds/issue/drupal-3447611/core/tests/Drupal/FunctionalJavascriptTests/Theme/ClaroViewsBulkOperationsTest.php:124
FAILURES!
Tests: 2, Assertions: 33, Failures: 1.

Now seeing the failing test on the MR. Removing tag

Believe feedback has been addressed, code change looks fine.

I read the IS, comments, and the MR. All questions are answered and the comments in the MR are fine.

Leaving at RTBC

Left some questions on the MR, feel free to self-RTBC after replying/changes

For the open threads. @bnjmnm assuming you wanted to take a look assigning the MR.