- Issue created by @Gábor Hojtsy
- Merge request !7438Update PhpRequirements.php with expected new EOL date (to be merged when announced) → (Closed) created by Gábor Hojtsy
- Merge request !7439Update PhpRequirements.php with expected updated PHP EOL dates → (Closed) created by Gábor Hojtsy
- Status changed to Needs work
7 months ago 8:07am 11 April 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
7 months ago 10:29am 11 April 2024 - 🇭🇺Hungary Gábor Hojtsy Hungary
Fails on the 10.3 MR were these, I sent for a retest for only those parts of the pipeline.
Drupal\Tests\standard\FunctionalJavascript\StandardPerformanceTest::testAnonymous Failed asserting that 3491 is identical to 3495. Drupal\Tests\demo_umami\FunctionalJavascript\OpenTelemetryFrontPagePerformanceTest::testFrontPageHotCache Failed asserting that 7067 is identical to 7075.
Also 7439 does not apply to 11.x, that is the 10.3 version, so ignore the NR bot.
- Status changed to Needs work
7 months ago 11:49am 11 April 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇬🇧United Kingdom catch
The 10.3 MR will need a rebase - those failures were fixed in 10.3 this morning.
- 🇭🇺Hungary Gábor Hojtsy Hungary
Gábor Hojtsy → changed the visibility of the branch 10.3.x to hidden.
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Added one comment.
Do note this date change is not yet reflected in the supported PHP versions https://www.php.net/supported-versions.php
- 🇭🇺Hungary Gábor Hojtsy Hungary
https://www.php.net/supported-versions.php happened so this should go into core now.
- 🇺🇸United States DamienMcKenna NH, USA
Is there any interest in reducing D11.0.0's requirement of PHP 8.3, or is that fixed in stone at this point?
- 🇬🇧United Kingdom catch
@DamienMcKenna that got discussed and decided against in 📌 Lower PHP requirement from 8.3 to 8.2 in Drupal 11 due to increased security support Closed: won't fix . If this had happened last year we might have decided differently, but we're already using PHP 8.3 syntax in core in a couple of places, so it would not only be lowering the requirement but also having to undo some other changes to add back support.
- 🇭🇺Hungary Gábor Hojtsy Hungary
The d10 branch/MR needs to be fixed up or redone. I don't currently have time to do that so help is welcome :)
- Status changed to Needs review
7 months ago 5:25pm 1 May 2024 - Status changed to RTBC
7 months ago 6:13pm 1 May 2024 - 🇭🇺Hungary Gábor Hojtsy Hungary
Although I worked on this, this is super simple, so will go ahead and RTBC it. The new dates are all in https://www.php.net/supported-versions.php and were adjusted to end of years.
-
longwave →
committed 8e036a94 on 11.x
Issue #3440114 by Gábor Hojtsy, andypost, catch, BramDriesen: Update PHP...
-
longwave →
committed 8e036a94 on 11.x
-
longwave →
committed cbd461cc on 10.2.x
Issue #3440114 by Gábor Hojtsy, andypost, catch, BramDriesen: Update PHP...
-
longwave →
committed cbd461cc on 10.2.x
-
longwave →
committed 0e1ca10d on 10.3.x
Issue #3440114 by Gábor Hojtsy, andypost, catch, BramDriesen: Update PHP...
-
longwave →
committed 0e1ca10d on 10.3.x
-
longwave →
committed e21d4b50 on 10.4.x
Issue #3440114 by Gábor Hojtsy, andypost, catch, BramDriesen: Update PHP...
-
longwave →
committed e21d4b50 on 10.4.x
- Status changed to Fixed
7 months ago 7:56pm 1 May 2024 - 🇬🇧United Kingdom longwave UK
Committed and pushed to 11.x, 10.4.x, 10.3.x and 10.2.x to keep everything in sync.