Automated Drupal 11 compatibility fixes for name

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.9
3. palantirnet/drupal-rector: 0.20.1

It works for me!

Can someone please make installable version .

liam morland → made their first commit to this issue’s fork.

@benstallings: Please do not set RTBC since it has been merged into a branch because the bot maybe adds changes later on.
@lkmorlan: awesome work! +1 Thanks a million. Question: Did you add your manual changes on the bot-only branch or do I miss something in the gitlab view? Shouldn't we add the changes to the 3433544-automated-drupal-11 branch to prevent the bot overriding it on next run?

I just rebased the changes that were already in the branch.

Oh, right, that's right. Now it rang a bell as to why it wasn't displayed for me. *facepalm*

I fixed the failing tests and added additional major/minor versions of Drupal Core to the pipeline.

Thank you. Upgrade_status errors are gone.
Only one warning regarding D12:

File name Line Error
web/modules/contrib/name/src/Element/Name.php 15 Class Drupal\name\Element\Name extends deprecated class Drupal\Core\Render\Element\FormElement. Deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. use Drupal\Core\Render\Element\FormElementBase instead.
Export as HTMLExport as text

If it is an easy fix: can we just fix that now?

It's an easy fix; here is an example.

If we replace FormElement with FormElementBase will the minimum Drupal version be 10.3?

If so, this sounds like something that can be slow walked. Drupal 12 is still a long time in the future. Maybe wait until Drupal 12 is available it the CI pipeline?

The minimum will be Drupal 10.3. Very soon this will be the oldest supported version of Drupal besides Drupal 7.

You can also use ::backwardsCompatibleCall() to have different code paths.

In addition to changing FormElement to FormElementBase. I changed the minimum Drupal version to 10.3

With 10.3 as the minimum, you can remove the call to version_compare().

There should be a newline at the end of .gitlab-ci.yml.

#17 has been addressed.
Tests are green.

So looks RTBC to me.

Minor feedback posted on the MR. I'll try to circle back to this tomorrow to resolve that, unless someone gets to it before me. Not removing RTBC for that minor nit.

heddn → credited adamzimmermann → .

Adding credit. Moving credit over from https://www.drupal.org/project/name/issues/3485754 🐛 Method signatures no longer compatible with diff's CoreFieldBuilder::build Active .

Thanks everyone for their contributions here.

Automatically closed - issue fixed for 2 weeks with no activity.