Automated Drupal 11 compatibility fixes for honeypot

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

This patch was created using these packages:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.7
3. palantirnet/drupal-rector: 0.20.1

Please open a new issue for changes to .gitlab-ci.yml

That file needs to be changed to support simultaneous testing against the current supported D10 version and also the future D11 version. It needs to configure the tests to run against the minimum supported version of PHP as well as the most recent version of PHP.

The purpose of these tests against the lowest-supported versions of Drupal core and PHP are so that new patches/MRs don't break existing sites.

The purpose of the tests against the latest Drupal core and PHP are so we get early warning of changes to core and/or PHP that might affect the operation of this module.

All these tests need to be run against all new MRs - it is not sufficient just to test the module against the latest HEAD.

Also read #3325483-4: Drupal Coding Standards Issues | phpcs → about some of your other changes. Likewise your changes to the header tests are unrelated and cause test failures. Regardless, this current issue is solely about D11 compatibility, not about PHPCS issues or testing configurations or anything else. Please don't mix unrelated changes together in one MR.

Running command ./vendor/bin/drush upgrade_status:analyze honeypot give following status which can be ignored, because its false positive contact/feedback-formis not a library.

================================================================================
Honeypot, --
Scanned on Fri, 05/31/2024 - 08:21

FILE: modules/contrib/honeypot/tests/src/Functional/HoneypotFormTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 304  The 'contact/feedback-form' library is not defined because  
                    the defining extension is not installed. Cannot decide if it
                    is deprecated or not.                                       
--------------------------------------------------------------------------------

FILE: modules/contrib/honeypot/tests/src/Functional/HoneypotFormCacheTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 93   The 'contact/feedback' library is not defined because the   
                    defining extension is not installed. Cannot decide if it is 
                    deprecated or not.                                          
--------------------------------------------------------------------------------
Check manually 96   The 'contact/feedback' library is not defined because the   
                    defining extension is not installed. Cannot decide if it is 
                    deprecated or not.                                          
--------------------------------------------------------------------------------
Check manually 103  The 'contact/feedback' library is not defined because the   
                    defining extension is not installed. Cannot decide if it is 
                    deprecated or not.                                          
--------------------------------------------------------------------------------
Check manually 105  The 'contact/feedback' library is not defined because the   
                    defining extension is not installed. Cannot decide if it is 
                    deprecated or not.                                          
--------------------------------------------------------------------------------
Check manually 110  The 'contact/feedback' library is not defined because the   
                    defining extension is not installed. Cannot decide if it is 
                    deprecated or not.                                          
--------------------------------------------------------------------------------

Regarding the the remaining test failure see MR:https://git.drupalcode.org/project/rules/-/merge_requests/26/diffs

Looks like all false errors in #7. Did you check it manually like the upgrade_status command told you to?

Honeypot does not define or use a contact/feedback library, so none of the output in #7 is valid.

The header asserts in the test cases are being addressed by 📌 PHPUnit: Fix Functional Tests 'HoneypotFormCacheTest' Needs review .

Thanks @TR, I ran the scan again today and I don't those issue reported in #7 hence moving in review.

================================================================================
Honeypot, --
Scanned on Mon, 06/03/2024 - 13:29

No known issues found.

@vishalkhode - I have remove those changes since its already covered here https://www.drupal.org/project/honeypot/issues/3450488 📌 PHPUnit: Fix Functional Tests 'HoneypotFormCacheTest' Needs review

The header asserts in the test cases are being addressed by #3450488: PHPUnit: Fix Functional Tests 'HoneypotFormCacheTest'

Ok, changes looks good to me.

@vishalkhode - I have remove those changes since its already covered here https://www.drupal.org/project/honeypot/issues/3450488 📌 PHPUnit: Fix Functional Tests 'HoneypotFormCacheTest' Needs review

The header asserts in the test cases are being addressed by #3450488: PHPUnit: Fix Functional Tests 'HoneypotFormCacheTest'

Hello @TR,

As you are the only active maintainer, It would be helpful if you could inform us when you intend to release a pre/stable version of honeypot as Drupal 11 stable is nearing its release date. Thanks!

deepakkm → changed the visibility of the branch project-update-bot-only to hidden.

Pipeline is now green , hence moving ahead for review.

Changes looks good, however I don't see CI running for Drupal 11, please add next major support in gitlab CI.

I will take of failing test on D11

Now all test are passing, hence requesting review.

Changes looks good and pipelines are executed a successful jobs, hence marking this one as RTBC

+1 RTBC.

Hello @TR,

We are approaching the release of Drupal 11, so should we expect this module to be compatible with Drupal 11? Thanks!

Resolved merge conflict.

To test Drupal 11 add to composer.json repositories section:

  "repositories": [
    {
      "type": "vcs",
      "url": "https://git.drupalcode.org/issue/honeypot-3430920.git"
    },

and then run

composer require drupal/honeypot:dev-3430920-automated-drupal-11

The 2.2.x branch is working on D11 for more than a week now, and it is being tested against D11 on a regular basis.
https://git.drupalcode.org/project/honeypot/-/pipeline_schedules

The 2.1.x branch will not be changed to support D11.

There will be a 2.2.0 release for the 2.2.x branch in the next week or so after I have seen if anyone reports problems with the upgrade.

Pull the finger out and update module description then. 👆

@TR Can you create release for 2.2 branch?

2.2.0 was released on 15 August will D11 support.

Automatically closed - issue fixed for 2 weeks with no activity.