Automated Drupal 11 compatibility fixes for field_group - Fixed PHPUnit on GitlabCI

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

This patch was created using these packages:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.7
3. palantirnet/drupal-rector: 0.20.1

The MR differs from the patch and there's no change to the .info.yml yet.

This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.10
3. palantirnet/drupal-rector: 0.20.1

Update MR to fix Drupal 11 compatibility issue, hence requesting review.

Here is the patch for the core_version_requirement.

The following PHPUnit tests are failing in Drupal 11:

Now, test with D10 as well as D11 passing, hence requesting review.

@chandu7929 : Reviewed changes and looks good to me.

Bumping to Major as an attempt to attract maintainers' attention:

Merge request MR!49 seems to be fixing the failing PHPUnit Tests in module's main development branch 8.x-3.x.

Getting these changes merged could unblock the automated testing of all current pending merge requests and help detecting potential regressions:
Pending merge requests: https://git.drupalcode.org/project/field_group/-/merge_requests

PHPUnit Tests all seem to be passing 🟢 \o/ 🎉

• See latest build on branch: https://git.drupalcode.org/issue/field_group-3430494/-/pipelines/175561
• Latest phpunit job on branch: https://git.drupalcode.org/issue/field_group-3430494/-/jobs/1620656

 
We would greatly appreciate if a maintainer or someone with write permission could take a look at ticket's merge request MR!49 and let us know if there would be any more work needed.

Once the PHPUnit Tests are fixed, we should be able to test again other tickets merge requests to ensure they're not breaking anything, for example:

• 📌 Fix the issues reported by phpcs Needs review : https://git.drupalcode.org/project/field_group/-/merge_requests/47
• 📌 GitlabCI: Fix CSPELL validation errors Active : https://git.drupalcode.org/project/field_group/-/merge_requests/53

and many more which are currently unable to be tested automatically with GitlabCI.

Feel free to let us know if you have any questions or concerns on merge request MR!49 or any aspect of this ticket in general, we would surely be glad to help.
Thanks in advance for your feedback and reviews.
 

Technical note:
Referencing here the warning message from PHPUnit about the Modernizr library (fixed in MR as well):

  1x: The core/modernizr asset library is deprecated in Drupal 10.1.0 and will be removed in Drupal 11.0.0. See https://www.drupal.org/node/3333253
    1x in MigrateUiFieldGroupTest::testFieldGroupMigrate from Drupal\Tests\field_group_migrate\Functional

nils.destoop → made their first commit to this issue’s fork.

Thx for the review. I did an extra check and removed the Modernizr dependency. It used to be a dependency, but this was removed in #2760835

Thanks a lot @nils.destoop for your prompt follow-up on this and for the extra clean-up!
Cheers!

Automatically closed - issue fixed for 2 weeks with no activity.

Thanks everyone here for getting Field Group Drupal 11 ready! Since the release is close (in about two weeks) would it make sense to make a Drupal 11 ready release of Field Group soon, to allow users to kick its tires and catch problems in advance?

Week of July 29, 2024 (UTC) | Drupal 11.0.0 released.

https://www.drupal.org/about/core/policies/core-release-cycles/schedule#... →

Hello @nils.destoop,

We are approaching the release of Drupal 11, so should we expect stable version for this module before that release? Thanks!