- Issue created by @dydave
- Merge request !53Issue #3447953 by DYdave: CSpell on GitlabCI: Fixed all validation errors such... → (Merged) created by dydave
- Status changed to Needs review
7 months ago 4:14pm 18 May 2024 - 🇫🇷France dydave
Quick follow-up on this issue:
A few additional commits were added to the current merge request MR!53 with a few comments, see above at #2.
But mostly, at this point:
Last build on MR!47: https://git.drupalcode.org/issue/field_group-3447953/-/pipelines/176739- The CSPELL job now seems to be passing ✅
CSPELL job: https://git.drupalcode.org/issue/field_group-3447953/-/jobs/1631188
- The PHPUnit Tests are passing as well 🟢 \o/
PHPUnit job: https://git.drupalcode.org/issue/field_group-3447953/-/jobs/1631189
Changes to file
MigrateUiFieldGroupTest.php
from merge request MR!49 (see 📌 Automated Drupal 11 compatibility fixes for field_group - Fixed PHPUnit on GitlabCI RTBC ) had to be ported to this MR for the phpunit tests to complete, see:
https://git.drupalcode.org/project/field_group/-/merge_requests/49/diffs...
So changes to this file could probably be reverted once the phpunit tests are fixed in the main development branch (8.x-3.x).
We would greatly appreciate if a maintainer or someone with write permission could take a look at ticket's merge request MR!53 and let us know if there would be any more work needed.
Feel free to let us know if you have any questions or concerns on merge request MR!53 or any aspect of this ticket in general, we would surely be glad to help.
Thanks in advance for your feedback and reviews. - The CSPELL job now seems to be passing ✅
- 🇧🇪Belgium nils.destoop
Hi. Thx for the merge request. I reviewed it and it is now being merged. The only risk is the renaming of some functions that could be used in custom code. But that should be an easy fix for the project.
-
DYdave →
committed 64dfb894 on 8.x-3.x
Issue #3447953 by DYdave: CSpell on GitlabCI: Fixed all validation...
-
DYdave →
committed 64dfb894 on 8.x-3.x
- Status changed to Fixed
7 months ago 8:47am 1 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.