Replace preg_match() with str_starts_with()/str_ends_with() or similar

Could you post the regex you used to find those?

It was a PHPStorm inspection that identified the changes and not manually, so I got no regex for you

Maybe something like this? Only for str_ends_with() replacements
https://regex101.com/r/cd29ZX/1

Thanks used that with also phpstorm (preg_match\('\/.*) got several 100 matches but reviewed a few dozen and didn't find any additional ones that were being suggested to replace.

I'm triaging RTBC issues → . I read the IS, the comments and the MR. I didn't find any unanswered questions.

I ran the inspection in PHPStorm which reported 6 problems in 4 files. Those are fixed here. There are two more changes here, one for \Drupal\Tests\views\Functional\Plugin\PagerTest::testNoLimit and the other in \Drupal\Tests\ComposerIntegrationTest::testComposerLockHash. How were these last two discovered?

I used the grep string from #8 which reports 138 matches in core. There may be more that can be changed but that should not prevent this improvement. We can also do a 'round 2'.

Leaving at RTBC;

For ComposerIntegrationTest, I asked in Slack if the replacement was valid, got only one positive response so I committed it.

As for the PagerTest, it came from a related issue and specifically this commit which was reverted there and added here

Committed and pushed 4d5abf7f08 to 11.x and cc7590905b to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.