[PP-1] [random test failure] KeyValueStore\DatabaseStorageTest fails randomly in multiple ways

Maybe this will do it. I guess it could be an NTP race condition or something like that.

Seems simple enough and pipeline is green.

We need a postgres run since that's the environment this most often fails on, and to use the (brand new) repeat test run button on the MR. Back to needs review for those.

https://git.drupalcode.org/project/drupal/-/jobs/256516
https://git.drupalcode.org/project/drupal/-/jobs/256532
https://git.drupalcode.org/project/drupal/-/jobs/256556
https://git.drupalcode.org/project/drupal/-/jobs/256557

So far green apart from an unrelated failure.

Actually https://git.drupalcode.org/project/drupal/-/jobs/256559 has happened twice, I wonder if this is introducing a new error. Need to do the same repeat runs against a clean 11.x

100 runs against HEAD https://git.drupalcode.org/project/drupal/-/jobs/256657
https://git.drupalcode.org/project/drupal/-/jobs/256673

That's a lot of test failures with the original issue so possibly this isfixing it.

Different random failure in the same test:

    Testing Drupal\KernelTests\Core\KeyValueStore\DatabaseStorageTest
    F.....                                                              6 / 6
    (100%)
    
    Time: 00:05.771, Memory: 4.00 MB
    
    There was 1 failure:
    
    1)
    Drupal\KernelTests\Core\KeyValueStore\DatabaseStorageTest::testConcurrent
    Failed asserting that actual size 6 matches expected size 10.
    
    /builds/project/drupal/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
    /builds/project/drupal/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
    /builds/project/drupal/core/tests/Drupal/KernelTests/Core/KeyValueStore/DatabaseStorageTest.php:86
    /builds/project/drupal/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
    

IMO this test is too fragile and we should just remove it altogether.

Requested push access to just rebase. There was a random javascript failure but the rebase is showing all green.

Discussed with @alexpott, we decided to mark the test skipped instead of removing it, then open up a follow-up to re-enable.

This might be failing to fork processes quickly enough because the CPUs are busy with other tests, so we might want a special test group that doesn't run with the other tests (needs to be handled in run-tests.sh) then runs in its own dedicated job.

Created 📌 Skip KeyValueStore\DatabaseStorageTest due to random test failures Active

Postponed on 📌 Skip KeyValueStore\DatabaseStorageTest due to random test failures Active

Adding what this is postponed on to the remaining tasks per Remining tasks → .

Setting to "Needs work" since 📌 Skip KeyValueStore\DatabaseStorageTest due to random test failures Active is now fixed.