Replace implementing deprecated interface Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface with ValueResolverInterface

------ ------------------------------------------------------------------------------- Line core/lib/Drupal/Core/Controller/ArgumentResolver/Psr7RequestValueResolver.php ------ ------------------------------------------------------------------------------- 15 Class Drupal\Core\Controller\ArgumentResolver\Psr7RequestValueResolver implements deprecated interface Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface: since Symfony 6.2, implement ValueResolverInterface instead ------ -------------------------------------------------------------------------------

------ ------------------------------------------------------------------------------ Line core/lib/Drupal/Core/Controller/ArgumentResolver/RouteMatchValueResolver.php ------ ------------------------------------------------------------------------------ 15 Class Drupal\Core\Controller\ArgumentResolver\RouteMatchValueResolver implements deprecated interface Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface: since Symfony 6.2, implement ValueResolverInterface instead ------ ------------------------------------------------------------------------------

Comments & Activities

Issue created by @Spokje
Comment 10 months ago →
🇳🇱Netherlands Spokje
Please don't tell me this would be a BC-break?
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 10 months ago
30,058 pass
@spokje opened merge request.
Status changed to Needs review 10 months ago10:16am 25 August 2023
Comment 10 months ago →
🇳🇱Netherlands Spokje
Status changed to RTBC 10 months ago2:48pm 25 August 2023
Comment 10 months ago →
🇺🇸United States smustgrave
Change looks good.
Status changed to Needs work 10 months ago3:09pm 25 August 2023
Comment 10 months ago →
🇬🇧United Kingdom catch
Will need a re-roll after 📌 Bump mglaman/phpstan-drupal to latest to make daily "updated deps" QA run pass again Fixed
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 10 months ago
Custom Commands Failed
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 10 months ago
30,058 pass
Status changed to RTBC 10 months ago4:05pm 25 August 2023
Comment 10 months ago →
🇳🇱Netherlands Spokje
Rerolled with PHPStan baseline suppression removed and re-RTBC-ed, since there were no code changes.
Comment 10 months ago →
🇳🇱Netherlands Spokje
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update 10 months ago
30,060 pass

Comment 10 months ago →

System Message

catch → committed 12dabf05 on 11.x

Issue #3383339 by Spokje: Replace implementing deprecated interface...

Status changed to Fixed 10 months ago8:25am 26 August 2023
Comment 10 months ago →
🇬🇧United Kingdom catch
The class still implements the method so from that point of view it's not a bc break. The class no longer implements the interface - this would be a problem if these were supposed to be type hinted anywhere, but they're only used by http bridge so I think that's OK too (although I hope I'm not wrong).

However, do we need a follow-up to deprecate and then remove methods like Psr7RequestValueResolver::supports() in 11.x? Should be cruft now.
Comment 10 months ago →
System Message
Spokje → closed merge request !4644
Comment 10 months ago →
🇳🇱Netherlands Spokje
Follow-up in 📌 Deprecate Psr7RequestValueResolver::supports and RouteMatchValueResolver::supports Fixed .
Comment 10 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Replace implementing deprecated interface Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface with ValueResolverInterface

Problem/Motivation

Steps to reproduce

Proposed resolution

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities