Deprecate Psr7RequestValueResolver::supports and RouteMatchValueResolver::supports

Since there's no usage of both supports() in core currently, I believe we don't need a deprecation test for this one?

Being final classes, maybe we can just remove the methods?

Would love that and it makes sense, but there currently doesn't seem to be any ruling on that in https://www.drupal.org/about/core/policies/core-change-policies/drupal-d... →

Maybe this could be the issue to enhance that?

I think argument resolvers would be covered under @internal insofar as they're equivalent to plugins and controllers and therefore not explicitly named. However also I think it's easier to deprecate + remove when in doubt same as we do for constructors unless something particularly makes that difficult.

Second thinking, it’s not just about extending classes but also about potential direct calls to the methods in these classes. So let’s deprecate - but now with PHPStan doing the check for calls, I think we should do the @deprecate and @see dance in the docblocks.

Ironic, and absolutely right, thanks @mondrake

Thanks!

Committed 58ce7d4 and pushed to 11.x. Thanks!

Spokje → closed merge request !4657

Added "Introduced in version" in CR.

Should it be published now or when 10.2.0 ships?

Now, but I frequently forget. Published.

Automatically closed - issue fixed for 2 weeks with no activity.