Bump mglaman/phpstan-drupal to latest to make daily "updated deps" QA run pass again

We expected the baseline to increase with this change. Its about 30% bigger, but that does make sense. A lot of deprecated code warnings.

This will affect the work we need to do when adding a deprecation since PHPStan will actually say 'watch it' when we deprecate something.

It might be usefull to have adding the deprecation to the phpstan baseline in the docs around deprecations → ? Although that could be a follow-up ( 📌 [Follow-up] In deprecation policy, document adding the deprecation to the phpstan baseline Active ).

Something we might need to consider, do we need to even have tests for testing the deprecation message? Couldn't this just be the fact phpstan reports is?

Hmm, this is the issue where this was decided to be ok: ✨ Use PHPStan for deprecation checking Active ? Not sure how these then relate. But based on that discussion this would be RTBC.

Unsure about the follow-up 📌 [Follow-up] In deprecation policy, document adding the deprecation to the phpstan baseline Active .

The normal procedure AFAIK is that calling deprecated code should be avoided and replaced in the issue that makes the code deprecated.
That would mean that in normal cases, there will be nothing for PHPStan to report?

The rare occasions where suppressions needed to be added to the PHPStan baseline seemed to have done so, so the process as is seems to be working and not changing?

Maybe I'm missing something?

On a much happier note:

Something we might need to consider, do we need to even have tests for testing the deprecation message? Couldn't this just be the fact phpstan reports is?

I think issues like 📌 Add @group legacy to EditorMediaDialogTest Fixed show that PHPStan is now already better at it then we are, so I'm all for dropping testing the deprecation message.

That should probably have policy/discussion follow-up when this is/will be committed?

I think we should go ahead here but continue discussing how to handle it in ✨ Use PHPStan for deprecation checking Active . Might feel differently if the baseline was nearly empty but it's very much not already.

phpstan updates often come with baseline additions/removals so comfortable committing as-is.

Committed/pushed to 11.x, thanks!

Spokje → closed merge request !4641

Automatically closed - issue fixed for 2 weeks with no activity.