Rearrange interfaces TranslatableRevisionableStorageInterface extends to fix deprecation warnings

Also. R before T so it fixes alphabetical sorting 🤷‍♂️. May not be testable until ✨ Use PHPStan for deprecation checking Active

Actually, it looks like I can fix this in phpstan-drupal after all. So it can bridge the gap without committing this https://github.com/mglaman/phpstan-drupal/pull/596

Nevermind, I forgot it asserts an incorrect error in the test:

        $errors = [];
        if (version_compare(\Drupal::VERSION, '10.1', '>=')) {
            $errors[] = [
                'Call to deprecated method loadRevision() of class Drupal\Core\Entity\EntityStorageInterface:
in drupal:10.1.0 and is removed from drupal:11.0.0. Use
\Drupal\Core\Entity\RevisionableStorageInterface::loadRevision instead.',
                12
            ];
        }

This is from:

$genericContentEntityStorage = \Drupal::entityTypeManager()->getStorage('foo');
assert($genericContentEntityStorage instanceof ContentEntityStorageInterface);
$genericContentEntityStorage->loadRevision(1);

So the generic content entity storage interface doesn't work due to ordering of extends.

We talked about this on Slack and there is no real possible problem that this could bring. Tests are also green. Setting rtbc

This is going to need a re-roll after 📌 Bump mglaman/phpstan-drupal to latest to make daily "updated deps" QA run pass again Fixed

Rebased the MR

Baseline updated, rebated, looking good.

Come to think of it: There might very well be a Coder follow-up in here to force the implements to be in alphabetical order?

Committed/pushed to 11.x, thanks!

Alphabetical implements seems worth opening a follow-up issue for if that'll help the phpstan baseline, would also match how we alphabetise use statements.

Opened Coder issue 📌 Check alphabetical ordering for "implements" Closed: outdated

Its not about alphabetical but about load order, so please don't force alphabetical :)

Also. R before T so it fixes alphabetical sorting 🤷‍♂️

Its not about alphabetical but about load order, so please don't force alphabetical :)

Confused now, but closed Coder issue anyway.

It's a cooincedence it's alphabetical, there is a load order to interfaces in php. Which is logica but very edge casey. We might run into this in the future. See the Slack thread.

Just copying in my Slack message in case people don't want to (or can no longer) go there.

The TL;DR is: "Although undocumented, PHP, consistently and by design, evaluates interfaces from right to left"

Automatically closed - issue fixed for 2 weeks with no activity.

Can this be also cherry-picked back to 10.1.x?

https://github.com/mglaman/phpstan-drupal/issues/621