Display the page title, even if "0" in olivero

Rechecked it and found that title is shown in claro but not in olivero. Updating the issue summary and title.

As the title field of a node is mandatory by default, removed the if condition to check the value of that. The reason that the title not rendering is due to the if condition as the value is 0 which is considered as FALSE.
Please review.

Rechecked it and found that title is also not shown in claro, hence updating the issue summary and title.

@kunal.sachdev i also find the same issue.

Follow the steps which you provided.

After the MR #8, issue has been resolved.

For reference:
Before MR

After MR

RTBC ++

Issue summary is incomplete.

Left some comments on MR.

Verified issue with new changes. Working as expected after MR!4437 .
Attaching Screenshots of results

Testing steps :
1. Use Olivero theme
2. Create a new node with title as "0". Title is not displayed.

Moving to RTBC++

The MR question was not answered.

Thanks @longwave.
Added the condition as title|render|striptags|trim is not empty so that if there are any tags it will remove it and check for the condition if it is empty. I think this is sufficient. Please review.

This MR applied successfully. Now the title is visible, and it is rendering fine.

The term "|render|striptags|trim" works well in twig.

After

Before

Moving to RTBC ++

I'm triaging RTBC issues → . I read the IS and the comments. I don't see any unanswered questions.

This issue is about olivero, I am changing the component.

For those adding screenshots, it is best to include a link in the issue summary so that everyone working on the issue can find the latest screenshots.

I then read the MR and it is good to see a thorough tests, and for multiple themes. This now has a dataprovider to test one page for three themes. To me, that is not a good use of resources. The testing could be done in a loop in the original test thus keeping the setup to one functional test. Perhaps, we leave this as is and add a followup to convert this test class to one method that uses a data provider. Adding tag for a followup.

There is also work in the MR.

#20 🐛 Display the page title, even if "0" in olivero Active : Instead of creating a follow-up to do testing in a loop I changed the test in this issue only.

Took the screenshots from #14 to the issue summary.

Believe feedback has been addressed,

test should be with other olivero-specific tests in \Drupal\FunctionalTests\Theme\OliveroTest or a file next to it.

feedback in MR

Seems the use of a bae class has been implemented.

nod_ → closed merge request !4473

nod_ → credited catch → .

Committed 00432f5 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.