- Issue created by @a.dmitriiev
- π©πͺGermany a.dmitriiev
Attaching the first patch. It is mostly the copy from EntityReferenceItem class
- last update
about 1 year ago Custom Commands Failed - Status changed to Needs review
about 1 year ago 3:26pm 7 July 2023 - last update
about 1 year ago 29,787 pass, 9 fail - π©πͺGermany a.dmitriiev
Uploading the patch that combines also match_limit and match_operator settings from related issue.
The last submitted patch, 5: 3373258-link-field-handler-settings-5.patch, failed testing. View results β
- Status changed to Needs work
about 1 year ago 3:51pm 10 July 2023 - π©πͺGermany a.dmitriiev
I have a question how now to change content of this file
core/modules/system/tests/fixtures/update/drupal-9.4.0.filled.standard.php.gz
, because now the trigger_error makes the tests fail - π©πͺGermany a.dmitriiev
Trying to fix tests and the logic of the update. Add update test.
- Status changed to Needs review
about 1 year ago 10:12am 13 July 2023 - last update
about 1 year ago 29,811 pass, 3 fail - last update
about 1 year ago 29,796 pass, 9 fail The last submitted patch, 7: 3373258-link-field-handler-settings-7.patch, failed testing. View results β
The last submitted patch, 9: 3373258-link-field-handler-settings-9.patch, failed testing. View results β
- last update
about 1 year ago 29,812 pass, 2 fail The last submitted patch, 13: 3373258-link-field-handler-settings-13.patch, failed testing. View results β
- last update
about 1 year ago 29,813 pass - π©πͺGermany a.dmitriiev
Fixing core/modules/link/tests/src/Functional/LinkFieldUITest.php test
- Status changed to Needs work
about 1 year ago 3:39pm 17 July 2023 - πΊπΈUnited States smustgrave
Could a CR be written for this new change and setting please.
- π©πͺGermany a.dmitriiev
I have created a change record https://www.drupal.org/node/3375174 β . This is my first change record, so please take it into account. Is it ok to have screenshots in the change record? Or it should be more "textish"?
- Status changed to Needs review
about 1 year ago 12:42pm 21 July 2023 - π©πͺGermany a.dmitriiev
I have rephrased the change record, so it is easier to read.
- Status changed to RTBC
about 1 year ago 4:47pm 21 July 2023 - πΊπΈUnited States smustgrave
On a standard install
Applied patch
Create a basic page and article page
Verified the post_update hooks run without issue.
Added a link field to the Article content type and only allowed link reference to Basic pages
Created another Article page and searching for article page from before didn't show up but basic page did. - last update
about 1 year ago 29,844 pass - last update
about 1 year ago 29,880 pass - last update
about 1 year ago 29,883 pass - last update
about 1 year ago 29,887 pass - last update
about 1 year ago 29,910 pass - last update
about 1 year ago 29,913 pass - last update
about 1 year ago 29,948 pass - last update
about 1 year ago 29,955 pass - last update
about 1 year ago 29,955 pass 52:54 51:44 Running- last update
about 1 year ago 29,960 pass - last update
about 1 year ago 29,960 pass - last update
about 1 year ago Build Successful - Status changed to Needs work
about 1 year ago 1:26pm 16 August 2023 - π³πΏNew Zealand quietone New Zealand
I am doing triage on the core RTBC queue β .
The patch needs an update, setting to needs work.
The issue summary is straight forward with a proposed resolution. This is making changes to the UI so I am adding the Usability tag. There are no unanswered items in the comments. The patch has been manually tested, including the post_update hook. But all changes need a code review as well.
@a.dmitriiev, thank you for your first change record! It has all the sections that it should. Nice job!
Looking at the screenshots in the CR, the first one has 'Browse available tokens' which is not a string in core. The screenshots are nearly always made from a 'standard' install. Can someone update that? I also think it would be easier for the reader if the 'Field Settings' screenshots were a smaller. If needed, they could just include the 'Allowed link type' and the 'Allow link text' section. Oh, and the text would benefit from some improvements for grammar and readability.
- π©πͺGermany a.dmitriiev
I have changed the images in change record.
- π³πΏNew Zealand quietone New Zealand
I changed the status of β¨ Port entity reference widget autocomplete settings to link field widget Closed: duplicate to duplicate, and now moving credit.
- π³πΏNew Zealand quietone New Zealand
Oh, I meant to remove a tag. And I think it was supposed to be 'needs change record updates'.
- Status changed to Needs review
8 months ago 2:06pm 28 December 2023 - π©πͺGermany a.dmitriiev
Anyone knows how to move forward here? What changes should be done to change record? Are there any instructions on how to proceed?
- Status changed to Needs work
8 months ago 11:51pm 1 January 2024 - πΊπΈUnited States smustgrave
I believe @quietone meant in #20 the tag should of been "needs change record updates" which appears you addressed in #21
But relooking at the patch it appears to be failing drupalCi, recommend turning into an MR for easier reviews.
Too many to list but all new functions should have a typehint return even if it's :void.
Deprecation can probably be bumped from 10.2 to 10.3
- Merge request !5993Issue #3373258 by a.dmitriiev, leymannx: Allow to select reference method in... β (Open) created by a.dmitriiev
- Status changed to Needs review
8 months ago 11:09am 2 January 2024 - Status changed to Needs work
8 months ago 2:38pm 2 January 2024 - Status changed to Needs review
8 months ago 4:21pm 3 January 2024 - π©πͺGermany a.dmitriiev
All new functions and their parameters now have typehints. Please review MR once again.
- Status changed to RTBC
8 months ago 6:25pm 4 January 2024 - last update
8 months ago Patch Failed to Apply - last update
8 months ago Patch Failed to Apply - πΊπ¦Ukraine Taran2L Lviv
Attaching a static patch from the latest changes in the MR (for composer patching purposes)
- last update
8 months ago Patch Failed to Apply - Status changed to Needs work
7 months ago 7:12am 5 February 2024 - π³πΏNew Zealand quietone New Zealand
I'm triaging RTBC issues β . I read the IS and the comments. I didn't find any unanswered questions.
I see that the issue summary has remaining tasks that I think are completed. But as I think this needs more input from UI folds. I am tagging for a UX review..