Allow to select reference method in link field type for internal links

Attaching the first patch. It is mostly the copy from EntityReferenceItem class

Forgot config schema changes.

Uploading the patch that combines also match_limit and match_operator settings from related issue.

The last submitted patch, 5: 3373258-link-field-handler-settings-5.patch, failed testing. View results →

Updating trigger_error format

I have a question how now to change content of this file core/modules/system/tests/fixtures/update/drupal-9.4.0.filled.standard.php.gz, because now the trigger_error makes the tests fail

Trying to fix tests and the logic of the update. Add update test.

The last submitted patch, 7: 3373258-link-field-handler-settings-7.patch, failed testing. View results →

The last submitted patch, 9: 3373258-link-field-handler-settings-9.patch, failed testing. View results →

Fixing tests.

The last submitted patch, 13: 3373258-link-field-handler-settings-13.patch, failed testing. View results →

Fixing core/modules/link/tests/src/Functional/LinkFieldUITest.php test

Could a CR be written for this new change and setting please.

I have created a change record https://www.drupal.org/node/3375174 → . This is my first change record, so please take it into account. Is it ok to have screenshots in the change record? Or it should be more "textish"?

I have rephrased the change record, so it is easier to read.

On a standard install
Applied patch
Create a basic page and article page
Verified the post_update hooks run without issue.
Added a link field to the Article content type and only allowed link reference to Basic pages
Created another Article page and searching for article page from before didn't show up but basic page did.

I am doing triage on the core RTBC queue → .

The patch needs an update, setting to needs work.

The issue summary is straight forward with a proposed resolution. This is making changes to the UI so I am adding the Usability tag. There are no unanswered items in the comments. The patch has been manually tested, including the post_update hook. But all changes need a code review as well.

@a.dmitriiev, thank you for your first change record! It has all the sections that it should. Nice job!

Looking at the screenshots in the CR, the first one has 'Browse available tokens' which is not a string in core. The screenshots are nearly always made from a 'standard' install. Can someone update that? I also think it would be easier for the reader if the 'Field Settings' screenshots were a smaller. If needed, they could just include the 'Allowed link type' and the 'Allow link text' section. Oh, and the text would benefit from some improvements for grammar and readability.

I have changed the images in change record.

quietone → credited leymannx → .

I changed the status of ✨ Port entity reference widget autocomplete settings to link field widget Closed: duplicate to duplicate, and now moving credit.

Oh, I meant to remove a tag. And I think it was supposed to be 'needs change record updates'.

Anyone knows how to move forward here? What changes should be done to change record? Are there any instructions on how to proceed?

I believe @quietone meant in #20 the tag should of been "needs change record updates" which appears you addressed in #21

But relooking at the patch it appears to be failing drupalCi, recommend turning into an MR for easier reviews.

Too many to list but all new functions should have a typehint return even if it's :void.

Deprecation can probably be bumped from 10.2 to 10.3

I have converted patch to MR.

All new functions and their parameters now have typehints. Please review MR once again.

Feedback has been addressed.

Attaching a static patch from the latest changes in the MR (for composer patching purposes)

I'm triaging RTBC issues → . I read the IS and the comments. I didn't find any unanswered questions.

I see that the issue summary has remaining tasks that I think are completed. But as I think this needs more input from UI folds. I am tagging for a UX review..