- Issue created by @leymannx
- Status changed to Needs review
over 1 year ago 1:00pm 7 July 2023 - last update
over 1 year ago Custom Commands Failed - π©πͺGermany a.dmitriiev
The patch is attached to add Matching settings, not only limit but also operator, the same as for entity autocomplete. The settings are only available in the widget settings when Link field instance supports internal links. By default limit is 10 and operator is "CONTAINS", for BC reasons. There is also an update hook done in the same way as system module did for autocomplete (see related issue).
- last update
over 1 year ago 29,777 pass, 12 fail - π©πͺGermany a.dmitriiev
Remove unused variable from post update that was breaking the tests.
The last submitted patch, 4: 3341689-link-match-settings-4.patch, failed testing. View results β
- π©πͺGermany a.dmitriiev
Fix hook name, I will check the failing tests a bit later
33:11 29:11 Running- Status changed to Needs work
over 1 year ago 6:35pm 7 July 2023 - πΊπΈUnited States smustgrave
This will need test coverage and an upgrade path tests for the schema changes.
Will need change record
New functions should be typhinted
@trigger_error() should follow pattern from other examples in core.
Also not sure using a hook here is the best but don't have any examples right nowDIdn't test the update hook
- Status changed to Needs review
over 1 year ago 7:04am 10 July 2023 - π©πͺGermany a.dmitriiev
The update hook is done in the same way as here https://www.drupal.org/project/drupal/issues/2863188 β , the same change, but for entity reference autocomplete widget.
- Status changed to Needs work
over 1 year ago 7:45am 10 July 2023 - πΊπΈUnited States smustgrave
That was 8.8 some different coding standards have been implemented since then.
- π©πͺGermany a.dmitriiev
Maybe this issue should be closed in favor of this one https://www.drupal.org/project/drupal/issues/3373258 β¨ Allow to select reference method in link field type for internal links RTBC because the last patch includes functionality from this issue.
- πΊπΈUnited States smustgrave
If the other solves the problem then we should. Will leave the call to you though since you worked on both.
The other ticket is on my list.
- Status changed to Fixed
over 1 year ago 7:04am 24 July 2023 - π©πͺGermany a.dmitriiev
Fixed in the referenced issue https://www.drupal.org/project/drupal/issues/3373258 β¨ Allow to select reference method in link field type for internal links RTBC
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Closed: duplicate
about 1 year ago 5:27am 8 September 2023 - π³πΏNew Zealand quietone
@a.dmitriiev, thanks.
This issue is really a duplicate (nothing was fixed here) so I changing the status.