- Issue created by @larowlan
- Status changed to Postponed
over 1 year ago 5:54am 4 July 2023 - ๐ซ๐ฎFinland lauriii Finland
+1. Let's get ๐ Consider replacing hook_field_type_category_info with YML based plugin discovery Fixed done first. ๐
- Status changed to Active
over 1 year ago 8:16am 24 July 2023 - ๐ซ๐ฎFinland lauriii Finland
Now that ๐ Consider replacing hook_field_type_category_info with YML based plugin discovery Fixed has been committed, this is unblocked.
- First commit to issue fork.
- last update
over 1 year ago 29,747 pass, 38 fail - @lauriii opened merge request.
- last update
over 1 year ago 29,877 pass - Status changed to Needs review
over 1 year ago 5:51pm 24 July 2023 41:07 40:26 Running- Status changed to Needs work
over 1 year ago 8:27pm 24 July 2023 - last update
over 1 year ago 29,879 pass - last update
over 1 year ago 29,879 pass - Status changed to Needs review
over 1 year ago 8:44pm 24 July 2023 - Status changed to RTBC
over 1 year ago 8:50pm 24 July 2023 - ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
Wasn't as big a cleanup as I hoped, but still seems cleaner. Thanks!
- last update
over 1 year ago 29,749 pass, 38 fail - last update
over 1 year ago 29,879 pass - last update
over 1 year ago Unable to generate test groups - last update
over 1 year ago 29,881 pass - Status changed to Needs review
over 1 year ago 12:21pm 25 July 2023 - Status changed to Needs work
over 1 year ago 12:55pm 26 July 2023 - ๐บ๐ธUnited States tim.plunkett Philadelphia
$ grep -nrA3 hook_preprocess_form_element__new_storage_type * | grep icon core/modules/datetime_range/datetime_range.module-35- $variables['#attached']['library'][] = 'datetime_range/drupal.datetime_range-icon'; core/modules/comment/comment.module-791- $variables['#attached']['library'][] = 'comment/drupal.comment-icon'; core/modules/telephone/telephone.module-42- $variables['#attached']['library'][] = 'telephone/drupal.telephone-icon'; core/modules/link/link.module-73- $variables['#attached']['library'][] = 'link/drupal.link-icon'; core/modules/media/media.module-540- $variables['#attached']['library'][] = 'media/drupal.media-icon';
There are still 5 modules using the preprocess hook to add in icon libraries.
- ๐บ๐ธUnited States tim.plunkett Philadelphia
@srishtiiee points out that these 5 are in the General category. My suggestion was to switch from a preprocess hook to hook_library_info_alter implementations, with each adding their own icons to a General category library.
- ๐ซ๐ฎFinland lauriii Finland
I remember I tried to implement this first using
hook_library_info_alter
but that might be tricky unless we get rid of the library definition and try to inject the assets directly to the library (which seems more hacky than the current solution). The problem is that the library we're adding depends on the existing library, and we want to load the existing assets before the new assets. If we wanted vice versa, it would be simple because we could just make the existing library depend on the new library. - last update
over 1 year ago 29,911 pass, 2 fail - last update
over 1 year ago 29,912 pass - Status changed to Needs review
over 1 year ago 1:08pm 31 July 2023 - last update
over 1 year ago 29,912 pass - last update
over 1 year ago 29,912 pass - Status changed to Needs work
over 1 year ago 3:16pm 2 August 2023 - ๐บ๐ธUnited States smustgrave
Think with a change like this a CR will be needed.
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
I think we are ok because this updates a feature that has only been added in 11.x and never been released?
- ๐บ๐ธUnited States smustgrave
But what if someone used this new feature as a patch? Not sure if that counts though.
- ๐บ๐ธUnited States tim.plunkett Philadelphia
This is an API addition to an unreleased feature, I agree it doesn't need a CR
- Status changed to RTBC
over 1 year ago 12:57pm 7 August 2023 - last update
over 1 year ago 29,954 pass - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,959 pass - last update
over 1 year ago 29,959 pass - last update
over 1 year ago 29,960 pass - Status changed to Needs work
over 1 year ago 7:57pm 15 August 2023 - last update
over 1 year ago 29,962 pass - last update
over 1 year ago 29,968 pass - Status changed to Needs review
over 1 year ago 6:18am 17 August 2023 - Status changed to Needs work
over 1 year ago 8:31am 17 August 2023 - ๐ฎ๐ณIndia kunal.sachdev
Looking great ๐. Needs work for two small nits.
- last update
over 1 year ago 29,972 pass - Status changed to Needs review
over 1 year ago 11:14am 17 August 2023 - Status changed to RTBC
over 1 year ago 6:51am 18 August 2023 - Status changed to Needs work
over 1 year ago 7:47am 18 August 2023 - ๐ซ๐ฎFinland lauriii Finland
This needs a rebase now that ๐ Retrieve field type category information in \Drupal\Core\Field\FieldTypePluginManager::getGroupedDefinitions Fixed has landed.
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,969 pass, 26 fail - last update
over 1 year ago 30,057 pass - Status changed to Needs review
over 1 year ago 10:13am 21 August 2023 - Status changed to Needs work
over 1 year ago 10:31am 21 August 2023 - last update
over 1 year ago 30,057 pass - Status changed to Needs review
over 1 year ago 1:16pm 21 August 2023 - Status changed to Needs work
over 1 year ago 9:12am 23 August 2023 - last update
over 1 year ago 30,045 pass, 2 fail - last update
over 1 year ago 30,057 pass - Status changed to Needs review
over 1 year ago 10:55am 23 August 2023 - Status changed to RTBC
over 1 year ago 8:44am 24 August 2023 - ๐ฎ๐ณIndia kunal.sachdev
Confirmed that there is no need for modules to implement preprocess hook for attaching asset libraries and all such hooks are removed.
- last update
over 1 year ago 30,056 pass, 1 fail - Status changed to Fixed
over 1 year ago 11:22am 24 August 2023 -
lauriii โ
committed d418da39 on 11.x
Issue #3372092 by srishtiiee, lauriii, larowlan, tim.plunkett, kunal....
-
lauriii โ
committed d418da39 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.