Retrieve field type category information in \Drupal\Core\Field\FieldTypePluginManager::getGroupedDefinitions

I realized it would be pretty nice if we could retain the existing behavior of this method because there are existing calls in contrib. Here's a patch that reverts back to the old behavior, which I think probably would be the most sensible thing to do for now.

Maybe we'd like to introduce something on top of this so that \Drupal\field_ui\Form\FieldStorageAddForm::buildForm didn't have to trigger hook_field_type_category_info directly.

This something that could use a change record for the new parameter?

Wrote a draft CR 👍

Thanks! CR looks good.

+++ b/core/lib/Drupal/Core/Field/FieldTypePluginManager.php
@@ -158,20 +158,50 @@ public function getFieldSettingsSummary(FieldDefinitionInterface $field_definiti
+   * @param string $category_label_key
+   *   (optional) The array key to use as the label of the category.
...
+      $category_info[$group]['key'] = $group;

I think this comment should mention the special key value that is also available.

We don't have to do #8 if we get 📌 Consider replacing hook_field_type_category_info with YML based plugin discovery Fixed in first. Postponing this until that has been committed.

📌 Consider replacing hook_field_type_category_info with YML based plugin discovery Fixed landed, this needs merging with the changes there.

Rerolled patch #3 📌 Retrieve field type category information in \Drupal\Core\Field\FieldTypePluginManager::getGroupedDefinitions Fixed in MR !4459

Can file.module line 1301 also use the constant?

RE: #15 📌 Retrieve field type category information in \Drupal\Core\Field\FieldTypePluginManager::getGroupedDefinitions Fixed I don't think we can remove it in this issue as it unrelated to the field type category system.

My question in #15 was answered.

Added a comment about the assertion testing.

On second thoughts let's just fix that in the linked issue, it doesn't need to hold this up.

Committed e8568a2 and pushed to 11.x. Thanks!

lauriii → closed merge request !4459

Automatically closed - issue fixed for 2 weeks with no activity.

Published change record.