- Issue created by @larowlan
- 🇫🇮Finland lauriii Finland
Converting to plugins would make implementing DX improvements like 📌 Allow field_type_categories.yml entries to define asset libraries Fixed easier too.
- First commit to issue fork.
- last update
over 1 year ago Custom Commands Failed - @srishtiiee opened merge request.
- last update
over 1 year ago 29,805 pass - Status changed to Needs review
over 1 year ago 11:17am 5 July 2023 - Status changed to Needs work
over 1 year ago 2:00pm 5 July 2023 - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,808 pass - Status changed to Needs review
over 1 year ago 7:35am 10 July 2023 - last update
over 1 year ago 29,809 pass - Status changed to Needs work
over 1 year ago 7:27pm 11 July 2023 - 🇺🇸United States tedbow Ithaca, NY, USA
Looking good. Glad we are doing this!
we also need a test for the new plugin manager
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,681 pass, 46 fail - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,783 pass, 4 fail - last update
over 1 year ago 29,821 pass - Status changed to Needs review
over 1 year ago 9:56am 17 July 2023 - Status changed to Needs work
over 1 year ago 11:29pm 17 July 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Left a review, also updated issue credits
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,821 pass - Status changed to Needs review
over 1 year ago 12:36pm 18 July 2023 - last update
over 1 year ago 29,825 pass - Status changed to RTBC
over 1 year ago 8:13am 19 July 2023 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
This looks good to go.
Adding tag for the followup to change $val to something else per review from @tedbow
Adding 'needs change record updates' to repurpose the one about the info hook to be about the new plugin-type
- Status changed to Needs work
over 1 year ago 2:44pm 19 July 2023 - 🇬🇧United Kingdom longwave UK
Some BC considerations and a bikeshed comment about the naming of this whole thing.
- last update
over 1 year ago 29,828 pass - Status changed to Needs review
over 1 year ago 7:48am 20 July 2023 - Status changed to RTBC
over 1 year ago 9:53am 20 July 2023 - 🇫🇮Finland lauriii Finland
Confirmed that the feedback has been addressed 👍 I also postponed 📌 Retrieve field type category information in \Drupal\Core\Field\FieldTypePluginManager::getGroupedDefinitions Fixed on this.
- 🇫🇮Finland lauriii Finland
Filed the follow-up issue: 📌 Rename $val in \Drupal\field_ui\Form\FieldStorageAddForm::buildForm to something more descriptive Fixed .
- Status changed to Needs work
over 1 year ago 12:51pm 20 July 2023 - 🇬🇧United Kingdom longwave UK
One more naming nitpick: plugin managers are singular, e.g.
plugin.manager.block
orplugin.manager.action
and also field plugin managers have a common namespace:plugin.manager.field.field_type
plugin.manager.field.widget
plugin.manager.field.formatter
Therefore I think the service name for this should be
plugin.manager.field.field_type_category
We also should add an interface for this:
interface FieldTypeCategoryManagerInterface extends PluginManagerInterface { }
We should typehint this interface in the FieldTypePluginManager constructor and docblock (instead of the generic PluginManagerInterface), and then also should add an interface alias so this service can be autowired:
Drupal\Core\Field\FieldTypeCategoryManagerInterface: '@plugin.manager.field.field_type_category'
- last update
over 1 year ago 29,831 pass, 2 fail - last update
over 1 year ago 29,832 pass - Status changed to Needs review
over 1 year ago 2:09pm 20 July 2023 - Status changed to RTBC
over 1 year ago 3:32pm 20 July 2023 - last update
over 1 year ago 29,833 pass - Status changed to Fixed
over 1 year ago 8:56am 21 July 2023 - 🇬🇧United Kingdom longwave UK
Committed and pushed f1a52222a7 to 11.x. Thanks!
Will publish the change records.
-
longwave →
committed f1a52222 on 11.x
Issue #3372097 by srishtiiee, lauriii, larowlan, longwave, tedbow:...
-
longwave →
committed f1a52222 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.