Rename $val in \Drupal\field_ui\Form\FieldStorageAddForm::buildForm to something more descriptive

Issue created by @lauriii
Comment over 1 year ago →
🇮🇳India sidharth_soman Bangalore
Would it be appropriate to replace $val with $field_option_data? If so, I can provide a patch for it.
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,826 pass
@anpel opened merge request.
Status changed to Needs review over 1 year ago11:31am 20 July 2023
Comment over 1 year ago →
anpel
Status changed to RTBC over 1 year ago4:11pm 20 July 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
Change looks good and rename makes more sense. Label and option not sure needs to be more complex haha.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,824 pass, 1 fail
Comment over 1 year ago →
anpel
Indeed #6 makes sense. Updated MR.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,840 pass
Status changed to Needs work over 1 year ago4:13pm 21 July 2023
Comment over 1 year ago →
🇫🇮Finland lauriii Finland
Posted proposals for the variable names in the MR 😊
First commit to issue fork.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
29,842 pass
Status changed to Needs review over 1 year ago6:14pm 21 July 2023
Comment over 1 year ago →
🇺🇸United States rpayanm
Please review.
Status changed to RTBC over 1 year ago12:29am 22 July 2023
Comment over 1 year ago →
🇺🇸United States smustgrave
That too.
Comment over 1 year ago →
System Message

lauriii → committed fb90a180 on 11.x
Issue #3375816 by anpel, rpayanm: Rename $val in...
Status changed to Fixed over 1 year ago5:45am 22 July 2023
Comment over 1 year ago →
🇫🇮Finland lauriii Finland
Committed fb90a18 and pushed to 11.x. Thanks!
Comment over 1 year ago →
System Message
lauriii → closed merge request !4419
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Rename $val in \Drupal\field_ui\Form\FieldStorageAddForm::buildForm to something more descriptive

Problem/Motivation

Comments & Activities