- Issue created by @Chris Matthews
- ๐บ๐ธUnited States DamienMcKenna NH, USA
Bumping the priority as the module currently doesn't have a stable release compatible with D10.
- ๐ง๐ชBelgium redseujac
Agreed. Isn't it time to have a new stable release for D10?
D10 is out since quite some time and so is 6.2.0-beta5 (released 12 jan 2023).
So, please...
- ๐บ๐ธUnited States DamienMcKenna NH, USA
@redseujac: Please help test out the child issues, let's see if we can get them to RTBC in the next few days!
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
6.2.x-dev tests are failing on PHP 8.0. Is 6.2.x intended to be compatible only with PHP 8.1 and greater? If we define it that way, it will match Drupal 10 and is a solid foundation for the future. 6.1.x-dev tests pass on PHP 8.1, so people can upgrade to PHP 8.1 while on 6.1.x then move to 6.2.x.
- ๐บ๐ธUnited States DamienMcKenna NH, USA
Bootstrap was updated to require PHP 8.1 when they added D10 support; should we ask them to remove this requirement until they drop D9 support?
- ๐บ๐ธUnited States DamienMcKenna NH, USA
I opened an issue for Bootstrap asking them to remove the PHP requirement: https://www.drupal.org/project/bootstrap/issues/3362715 โจ Please support PHP 8.0 while Drupal 9 is supported Needs review
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
That would be good even if only for 6.1.x. We could still decide that 6.2.x should require PHP 8.1.
- ๐บ๐ธUnited States jrockowitz Brooklyn, NY
I think for 6.2.x we should require PHP 8.1+.
- ๐ง๐ชBelgium redseujac
jrockowitz commented in #9:
I think for 6.2.x we should require PHP 8.1+.
So do I.
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
We should also consider when support will end for Webform 6.0.x. A sizeable majority of people have moved to 6.1.x, so I think it would be reasonable to do this.
- ๐บ๐ธUnited States jrockowitz Brooklyn, NY
I am hoping that Webform 6.0.x support can end when 6.2.x is released. It is reasonable only to support the two latest major releases.
- ๐ง๐ชBelgium redseujac
That makes sense.
I am using Drupal 10.0.9, PHP 8.2.6, Webform 6.2.x-dev (most recent build).
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
I agree.
Another suggestion: For 6.2.x, make the minimum Drupal version be 9.5. People can stay on 6.1.x until they are on Drupal 9.5.
- ๐ญ๐บHungary jan.mashat
Hi, may I ask when are you planning to release 6.2.0?
Is there anything that can be done to help with the effort?Do these 3 major bug fixes need to get merged first?
- Private fields not shown to users with "View webform submissions for own node" permission ๐ Private fields not shown to users with "View webform submissions for own node" permission Needs review
- Export and access checks ๐ Export and access checks Needs review
- [Paragraphs] Email handler sends "_default" in body when embedding webform in Paragraph ๐ [Paragraphs] Email handler sends "_default" in body when embedding webform in Paragraph Fixed
- ๐บ๐ธUnited States jrockowitz Brooklyn, NY
I appreciate any help and understand the need for a stable release of the Webform. At the same time, the beta version is very stable. The Webform module has a good track record between beta-to-beta releases.
I have less time and interest in maintaining and improving the Webform module. It does what it does, and it does it fairly well.
This does not mean I'm leaving the Drupal community or not maintaining this module. It does mean I want the 6.2.x release to be as stable as possible. For example, fixing ๐ฑ Plan for Webform 6.2.0 Release Active will require some work over the summer.
I'd like to address most open issues before the first RC release. I need help reviewing any 'Needs Review' ticket, especially if I've posted the patch. Comments and thoughts are always appreciated.
I am open to ๐ฑ Co-maintenance plan for the Webform project Active , but it requires someone who either knows the Webform module inside-n-out or is willing to improve and write tests for every patch.
BTW, there should be enough funds to get us a stable release in the Webform module's Open Collective. I do use these funds to support my ongoing work on the module. It does help when an organization or individual sponsors the Webform module's Open Collective.
- ๐ญ๐บHungary jan.mashat
At the same time, the beta version is very stable.
Beta versions unfortunately don't receive coverage from the security team, so a stable release would help there.
Is it safe to assume that Webform will not have a stable D10 release by the time D9 reaches EOL (in 3 months)?
- ๐บ๐ธUnited States drupgirl
+1 on jrockowitz commented in #9:
I think for 6.2.x we should require PHP 8.1+.
- ๐บ๐ธUnited States Chris Matthews
@jrockowitz, would it be possible to tag 6.2.0 for security coverage and then continue with 6.2.1 for the remaining issues that need to be fixed?
- ๐ฎ๐ณIndia Sana.Neyazi
Hi @jrockowitz
Could we know by when we can expect Drupal 10 stable release of webform? - ๐ฎ๐ณIndia kaustavbagchi
Hi, When are we expecting a stable release compatible to Drupal 10? Any major road blockers or issues which needs to be fixed? Thanks
- ๐บ๐ธUnited States DamienMcKenna NH, USA
@kaustavbagchi: Please see the list of child issues in the right sidebar - some need review, some need work, any help would be appreciated.
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
For those unable to read the image, it says:
jrockowitz 10:04 AM
I don't have a lot of extra time. I am not sure when I will be able to tag the stable release but the next release will be an RC. - ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
Given the tight timelines and lack of extra time, I suggest the following:
- Mark Webform 6.0 as unsupported. It is comparatively little-used and is only needed for versions of Drupal that have not been supported in a long time.
- End development on Webform 6.1 except for security updates. There will soon be no supported version of Drupal that can run it.
- Focus exclusively on making Webform 6.2 stable enough for release (no feature development or even fixing bugs that already exist in 6.1) and compatible with Drupal 10.0 (if additional work is needed for 10.1 compatibility, that can wait until November).
- ๐บ๐ธUnited States Chris Matthews
All great proposals IMO. I also think discussion is needed re: the long-term maintenance of Webform. Maybe the module's maintenance status should be changed to Seeking co-maintainer(s) (Maintainers are looking for help reviewing issues.) @jrockowitz, along with many others, have done an absolutely incredible job over the years building and maintaining webform, but maybe it needs some additional backing from leading Drupal shops who could provide maintenance support (reviewing patches, committing, etc.)
- ๐บ๐ธUnited States jrockowitz Brooklyn, NY
Here is the reality when it comes to co-maintainers: before anyone can become a co-maintainer, they need to review patches and contribute code with test coverage demonstrating the ability and commitment to co-maintaining the Webform module.
Some agencies would say they want to be co-maintainers when only seeking commit credits and would immediately tag a broken stable release of 6.2.x.
I apologize if my above statements are too direct and maybe bitter.
I do agree with everything noted in #27
I agree with @jrockowitz. Merely triaging some issues (as I do) or rolling releases (as I am capable of doing) isnโt enough. A co-maintainer of this module at this point in time must also have a good handle on the internals.
And the truth is there is no such a person right now and I say that as someone who follows every issue closely.
- ๐บ๐ธUnited States Chris Matthews
Should the module's maintenance status be changed to Seeking co-maintainer(s)? Or, is that not very helpful given the comments above?
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
I have updated the project page based on #27 and approval by @jrockowitz in #29.
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
Also for branch management, the 6.x branch should be left pointing at 6.1.x and not moved to 6.2.x.
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
@jrockowitz and I have been working towards a full release of Webform 6.2.0. A new beta has been released. Most child tickets of this issue are closed.
Please test the new beta and let us know if you are aware of anything that needs to be fixed before a full release, in particular, any functionality that would be lost by moving from the latest 6.1 to 6.2.x.
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
Webform 6.2.0-rc1 has been released. The focus is on fixing any release-blocker bugs that emerge.
- ๐บ๐ธUnited States Chris Matthews
Is there an existing issue re: removing all of the deprecated webform submodules?
- Webform Algolia Places (Deprecated)
- Webform iCheck (Deprecated)
- Webform jQueryUI Buttons (Deprecated)
- Webform jQueryUI Datepicker (Deprecated)
- Webform Location Geocomplete (Deprecated)
- Webform Toggles (Deprecated)
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
Not that I am aware of. It feels very late in the release process to be removing sub-modules.
I don't think we could remove them except in a major release. Any deprecated things should be removed in version 7.
-
Liam Morland โ
committed 1fba118d on 6.2.x
Issue #3358973: Require PHP 8.1
-
Liam Morland โ
committed 1fba118d on 6.2.x
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
I have released Webform 6.2.0-rc2.
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
I have released Webform 6.2.0-rc3.
- ๐บ๐ธUnited States jrockowitz Brooklyn, NY
I am okay with tagging the stable release on October 30th.
@Liam Morland Thank you for helping move this forward
- ๐บ๐ธUnited States kmonty San Francisco, CA
I won't go as far as modifying the child issues, but calling out we found a breaking regression that was implemented in beta7. ๐ Regression > Patch for "webform entity reference formatters not supporting translations" in 6.2.0-beta7 breaks Webform embeds within untranslated entities Active
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
@kmonty We'll probably need to rollback that patch as you suggest so that the upgrade does not cause a regression.
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
I have reverted ๐ webform entity reference formatters do not support translations Needs review and released Webform 6.2.0-rc4 with that change.
- ๐บ๐ธUnited States drupals.user
Will you please provide an update if there are any issues with 6.2.0-rc4 and a stable branch being released?
We have been holding off on upgrading our productions sites to Drupal 10 until this module releases a stable branch, and tomorrow is the last day prior to end-of-life for Drupal 9 on November 1, 2023.
- ๐ฎ๐ณIndia sundaravigneshP
I have working in my local drupal setup its working fine,after adding a signature element to a form, and testing,the signature image is displayed in Results & also to update the signature element.
Other info(My local setup version details):
- Drupal version : 10.1.5
- PHP OS : Linux
- PHP version : 8.2.5
- Drush version : 12.4.1.0
- Webform version: ^6.2@RC
- Status changed to Fixed
about 1 year ago 1:58pm 30 October 2023 - ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
Webform 6.2.0 has been released! Thank you, all.
- ๐บ๐ธUnited States DamienMcKenna NH, USA
sundaravigneshP: Please open a new issue if you need help with something.
Huge thanks to jrockowitz for the leadership and Liam Morland for pushing the release past the finish line!
- ๐ฌ๐งUnited Kingdom nicrodgers Monmouthshire, UK
Woohooo - thank you so much!
- ๐บ๐ธUnited States drupals.user
Congratulations on getting this over the finish line!!!! Very much appreciated!!!!
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
about 1 year ago 11:24am 16 November 2023 - ๐ฏ๐ตJapan ilfelice
Howdy,
Just wanted to let you all know that I upgraded 3 sites from Drupal 9.5 to 10, and Webform 6.2 is working like a charm in all of them.
Great work! Many thanks!