- Issue created by @DamienMcKenna
- Status changed to Needs review
over 1 year ago 2:21pm 25 May 2023 - Open on Drupal.org βCore: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - πΊπΈUnited States DamienMcKenna NH, USA
This patch removes the line from composer.json.
- πΊπΈUnited States DamienMcKenna NH, USA
This is affecting the tests on Webform 6.2 against PHP 8.0.
- Open on Drupal.org βCore: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - πΊπΈUnited States DamienMcKenna NH, USA
#2 missed the info file, which also indicated 8.1 was required.
This changes both composer.json and bootstrap.info.yml to require PHP 8.0.
- last update
over 1 year ago Build Successful The last submitted patch, 4: bootstrap-n3362715-4.patch, failed testing. View results β
- πΊπΈUnited States DamienMcKenna NH, USA
Setting this to "needs review" as the branch doesn't have any tests, so the testbot failure is a misdirection.
- πΊπΈUnited States shelane
Can you review the comments for https://www.drupal.org/project/bootstrap/issues/3302607#comment-14828430 π Drupal 10 compatibility fixes Fixed
Specifically 18, 19, and 20?
With this function, how do I support both or will it just be fine if PHP 8.0 is the minimum?
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
A good starting point would be to configure the automated tests to run on both versions and see if that works.
- Status changed to Closed: won't fix
4 months ago 4:41pm 13 September 2024 - π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Does
bootstrap
actually need PHP 8.1? Unless it actually has a PHP requirement that is greater than the versions of Drupal core that it claims to run on, then it shouldn't declare a PHP dependency at all. - Assigned to shelane
- Status changed to Active
4 months ago 2:13pm 14 September 2024 -
shelane β
committed 171f5314 on 8.x-3.x
Issue #3362715 by damienmckenna, shelane: Please support PHP 8.0 while...
-
shelane β
committed 171f5314 on 8.x-3.x
- Issue was unassigned.
- Status changed to Fixed
4 months ago 8:27pm 14 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.