- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
I am having the same problem and the patch fixes it for me. It could also be fixed by comparing to
<p>_default</p>
or<p>static::DEFAULT_VALUE</p>
instead of usingstrip_tags()
.It is also fixed by the work-around described in #5.
The webform does not need to be embedded in a paragraph for this to happen.
- π§πͺBelgium nightlife2008
Hi everyone,
I stumbled upon this issue because of a problem one of our customers has when translating a webform.
When having an email handler in the source webform, the body of this email handler's email is displayed as a richtext field, which, by default, encapsulates the "_default" string in
tags, which later breaks the sending of the emails:
- π§πͺBelgium weseze
Also experiencing this issue.
We are not using paragraphs, so nothing to do with paragraphs specifically
We are also not using any custom text format for the elements/emails, everything is default webform.
I checked all the settings for emails, formats and the dedault webform ckeditor profile: everything is exactly as the default webform config provides it after installation.Mail body texts are translated with a ckeditor, and the "_default" text is wrapped in p-tags. So all translated emails are wrong for us, unless we specifically translate them, or remove the p-tags in the source code of the ckeditor.
Provided patch here, fixes our issue.
- πΊπΈUnited States jrockowitz Brooklyn, NY
I don't like working around the root cause, which is when translating the email body when it is set to default, it should not even display the 'default' value or the HTML editor.
- last update
about 1 year ago 532 pass, 1 fail - πΊπΈUnited States jrockowitz Brooklyn, NY
The attached patch goes after the root cause.
The issue is so significant it is very unlikely that no one has allowed the broke configuration to remain, I am not sure we need any update hook to fix a bug in beta software.
The last submitted patch, 13: 3304518-13.patch, failed testing. View results β
- Status changed to Needs work
about 1 year ago 3:54pm 4 October 2023 - last update
about 1 year ago 532 pass, 1 fail - last update
about 1 year ago 532 pass, 1 fail - last update
about 1 year ago 532 pass, 1 fail - π¨π¦Canada Liam Morland Ontario, CA π¨π¦
This is the patch in #13 plus just enough test changes to make it pass. This is not to commit but to show what tests are failing.
- last update
about 1 year ago 536 pass - last update
about 1 year ago 536 pass - last update
about 1 year ago Composer require-dev failure - last update
about 1 year ago 536 pass - πΊπΈUnited States jrockowitz Brooklyn, NY
We shouldn't comment out the tests. The selectors need to be updated.
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Yes, that patch is not to be committed. That is why I left the issue as "Needs work". The patch is there to demonstrate what tests are not passing and show that the rest of the tests do pass.
- Status changed to Needs review
about 1 year ago 12:13pm 7 October 2023 - last update
about 1 year ago 536 pass - πΊπΈUnited States jrockowitz Brooklyn, NY
@Liam Thanks
If the tests pass this should be RTBC.
- last update
about 1 year ago 536 pass - last update
about 1 year ago 536 pass -
Liam Morland β
committed f10b0ace on 6.2.x authored by
jrockowitz β
Issue #3304518 by jrockowitz, daniel.pernold, Liam Morland, StephaneQ,...
-
Liam Morland β
committed f10b0ace on 6.2.x authored by
jrockowitz β
-
Liam Morland β
committed 4108e017 on 6.2.x authored by
jrockowitz β
Issue #3304518 by jrockowitz: Improve test comments
-
Liam Morland β
committed 4108e017 on 6.2.x authored by
jrockowitz β
- Status changed to Fixed
about 1 year ago 1:08pm 7 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.