- Issue created by @alexpott
- ๐ฌ๐งUnited Kingdom AaronMcHale Edinburgh, Scotland
I would recommend adding ๐ Convert announcements feed from toolbar to dashboard Postponed
- ๐ช๐ธSpain fjgarlin
Agree. Two of the issues depend on the "dashboard" functionality being implemented. I made that clear in the issue description.
- Status changed to RTBC
about 1 year ago 4:30pm 2 November 2023 - ๐บ๐ธUnited States hestenet Portland, OR ๐บ๐ธ
I believe this is RTBC - and ready for project announcements to be marked Stable.
There are follow ups for Dashboard but they can happen as part of the Dashboard work directly.
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 7:56am 7 November 2023 - ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
Not 100% sure if this is "the" issue, but created a MR to actually mark the module as stable.
- Status changed to RTBC
about 1 year ago 10:02am 7 November 2023 - ๐ฌ๐งUnited Kingdom longwave UK
This looks good to me - all blockers are fixed, the module is small and self contained and we haven't had reports of any issues, so I think this is good to go in 10.2.0.
- ๐ซ๐ทFrance andypost
I bet it needs CR and probably release notes snippet
- Assigned to BramDriesen
- Issue was unassigned.
- ๐ซ๐ฎFinland lauriii Finland
Tagging with the appropriate tags to get this approved.
- ๐ฌ๐งUnited Kingdom catch
+1 from me. Pretty self contained and got a fair bit of review when we initially committed it.
- ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
Reviewed this extensively when it went in. Happy to remove the FM tag.
Do we have an issue to add this to the standard profile?
- ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
Do we have an issue to add this to the standard profile?
No I donโt think so. You want to add it here?
- ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
A follow up issue is fine
- ๐บ๐ธUnited States xjm
Increasing the stability of modules also requires RM review, so tagging for that too.
- ๐ฌ๐งUnited Kingdom catch
It's tricky when the tag is never added because then you can't ctrl-f for it being removed, but yeah officially removing it now since both me and @longwave have +1d already.
- ๐ฌ๐งUnited Kingdom catch
Also I don't think this needs FEFM review, that would only be the case if it was bringing in new js libraries or API, neither of which it does, so removing the tag on their behalf.
- ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
Cool only Product manager review left then.
Btw, is there a documentation page about those tags? I can't quite wrap my mind around which one to add when ๐ it's just gut instinct based on issues I've seen. I ended up here: https://www.drupal.org/node/2457875#faq-tags โ but that only shows which tags there are, not really when to use them. Some explanation is shown when hovering over the tag when it's added, but yeah that only works when they are added and saved to the issue.
- ๐ฌ๐งUnited Kingdom longwave UK
- ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
@longwave Thanks! Bookmarked ๐
- ๐บ๐ธUnited States xjm
@lauriii In the future it'd be helpful to ask the individual whether they're formally signing off or not; sometimes a +1 is just an individual opinion and other times it's a terse signoff. :) Also adding the tag gives others in the role a chance to see the issue if they did not before.
@longwave and @catch mention code reviews, but not any evaluation of the module's technical debt. I checked that to be safe and the very pleasant result is "there isn't any":
https://www.drupal.org/project/issues/search/drupal?project_issue_follow... โTwo things I've wished for from the announcements feed are improving the governance of what goes in, and also making it a bit less "break glass in case of emergency, drumm runs a drush command" to get new announcements out. However, neither of those things need to be stable blockers. So I'm fine with it being marked stable also.
Additionally, we should add this to Standard once it's stable (or maybe at the same time as marking it stable).
- ๐บ๐ธUnited States xjm
Oh @BramDriesen you can also review the core governance to understand in more detail the different types of committers and what their responsibilities are. That said, it's also okay to not have a complete understanding, because issues can be RTBC with any of the committer signoff tags on them, and the committers know whose responsibilities are what and can fix the tags as needed.
- ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
Not sure if you've see it @xjm but โจ Add Announcements Feed to the standard profile RTBC is the follow-up to add it to the standard profile. You did see the one for Unami ๐
Thanks as well for the link to the core governance and your guidance!
-
lauriii โ
committed 645d5de9 on 11.x
Issue #3356488 by BramDriesen, xjm, catch, fjgarlin, hestenet, longwave...
-
lauriii โ
committed 645d5de9 on 11.x
-
lauriii โ
committed 8c1896e0 on 10.2.x
Issue #3356488 by BramDriesen, xjm, catch, fjgarlin, hestenet, longwave...
-
lauriii โ
committed 8c1896e0 on 10.2.x
- Status changed to Fixed
12 months ago 7:31am 20 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.