Mark Announcements Feed as stable

I would recommend adding 📌 Convert announcements feed from toolbar to dashboard Postponed

Agree. Two of the issues depend on the "dashboard" functionality being implemented. I made that clear in the issue description.

I believe this is RTBC - and ready for project announcements to be marked Stable.

There are follow ups for Dashboard but they can happen as part of the Dashboard work directly.

Not 100% sure if this is "the" issue, but created a MR to actually mark the module as stable.

This looks good to me - all blockers are fixed, the module is small and self contained and we haven't had reports of any issues, so I think this is good to go in 10.2.0.

I bet it needs CR and probably release notes snippet

I can do that :)

Tagging with the appropriate tags to get this approved.

+1 from me. Pretty self contained and got a fair bit of review when we initially committed it.

Reviewed this extensively when it went in. Happy to remove the FM tag.

Do we have an issue to add this to the standard profile?

Do we have an issue to add this to the standard profile?

No I don’t think so. You want to add it here?

A follow up issue is fine

+1 rtbc as follow-up added

Increasing the stability of modules also requires RM review, so tagging for that too.

@xjm FWIW, I didn't tag it with needs release manager review because this received RTBC from @longwave and @catch +1'd this in #17.

It's tricky when the tag is never added because then you can't ctrl-f for it being removed, but yeah officially removing it now since both me and @longwave have +1d already.

Also I don't think this needs FEFM review, that would only be the case if it was bringing in new js libraries or API, neither of which it does, so removing the tag on their behalf.

Cool only Product manager review left then.

Btw, is there a documentation page about those tags? I can't quite wrap my mind around which one to add when 😅 it's just gut instinct based on issues I've seen. I ended up here: https://www.drupal.org/node/2457875#faq-tags → but that only shows which tags there are, not really when to use them. Some explanation is shown when hovering over the tag when it's added, but yeah that only works when they are added and saved to the issue.

@BramDriesen see https://www.drupal.org/docs/develop/issues/fields-and-other-parts-of-an-... →

@longwave Thanks! Bookmarked 😇

@lauriii In the future it'd be helpful to ask the individual whether they're formally signing off or not; sometimes a +1 is just an individual opinion and other times it's a terse signoff. :) Also adding the tag gives others in the role a chance to see the issue if they did not before.

@longwave and @catch mention code reviews, but not any evaluation of the module's technical debt. I checked that to be safe and the very pleasant result is "there isn't any":
https://www.drupal.org/project/issues/search/drupal?project_issue_follow... →

Two things I've wished for from the announcements feed are improving the governance of what goes in, and also making it a bit less "break glass in case of emergency, drumm runs a drush command" to get new announcements out. However, neither of those things need to be stable blockers. So I'm fine with it being marked stable also.

Additionally, we should add this to Standard once it's stable (or maybe at the same time as marking it stable).

Oh @BramDriesen you can also review the core governance to understand in more detail the different types of committers and what their responsibilities are. That said, it's also okay to not have a complete understanding, because issues can be RTBC with any of the committer signoff tags on them, and the committers know whose responsibilities are what and can fix the tags as needed.

Not sure if you've see it @xjm but ✨ Add Announcements Feed to the standard profile RTBC is the follow-up to add it to the standard profile. You did see the one for Unami 😉

Thanks as well for the link to the core governance and your guidance!

lauriii → closed merge request !5274

This seems fine for me to mark as stable so that we can enable it by default and start collecting feedback.

Committed 645d5de and pushed to 11.x. Also cherry-picked to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.