- Issue created by @hestenet
- Status changed to Postponed
over 1 year ago 4:29pm 21 March 2023 - 🇺🇸United States hestenet Portland, OR 🇺🇸
Postponed on further progress on: 🌱 Enhance user experience with customizable dashboards Active
- 🇪🇸Spain plopesc Valladolid
In order to integrate announcements feed into the dashboard, ✨ Provide a block with DA announcements Needs review was created.
It provides a block and some tests in the attached patch.
Would be great to include this new block as part of the announcements module.
That would be the 1st step to integrate it within dashboards as soon as they are available.
What do you think?
- last update
about 1 year ago Custom Commands Failed - @plopesc opened merge request.
- Status changed to Needs review
about 1 year ago 1:01pm 20 October 2023 - 🇪🇸Spain plopesc Valladolid
Thank you for the quick response!
Created MR with 1st approach to include the Announcements block in the module.
Thanks!
- last update
about 1 year ago Unable to generate test groups 20:54 44:34 Running- last update
about 1 year ago 30,428 pass - Status changed to RTBC
about 1 year ago 8:24am 23 October 2023 - 🇪🇸Spain fjgarlin
This is a great refactoring into a reusable service, leaving both the controller and the block definition in a very clean way. Thanks for adding additional tests as well for the new service and the block.
I reviewed the code and couldn't find anything to report, so it looks good from my end. I also tested the new block via the UI using block layout and it looks good. I tested logged in and logged out too.
Tests are passing for both DrupalCI and GitLabCI.
Marking this RTBC.
- last update
about 1 year ago 30,429 pass - last update
about 1 year ago 30,440 pass - Status changed to Needs work
about 1 year ago 5:44pm 26 October 2023 - 🇫🇮Finland lauriii Finland
Posted a minor nitpick on the MR. Feel free to move back to RTBC after addressing the feedback.
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
We should provide credit also to friera, who worked initially on this as part of the dashboard initiative: https://www.drupal.org/project/3327580/issues/3375851 ✨ Provide a block with DA announcements Needs review
- last update
about 1 year ago 30,441 pass - Status changed to RTBC
about 1 year ago 6:52am 27 October 2023 - Status changed to Fixed
about 1 year ago 11:22am 27 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.