- Issue created by @fjgarlin
- Status changed to Active
over 1 year ago 8:02am 28 April 2023 - last update
over 1 year ago Custom Commands Failed - @fjgarlin opened merge request.
- Status changed to Needs review
over 1 year ago 9:00am 28 April 2023 - 🇪🇸Spain fjgarlin
Ready to review.
Enable the module and you should see something like this:
- last update
over 1 year ago 29,365 pass, 1 fail - last update
over 1 year ago 29,367 pass - Status changed to Needs work
over 1 year ago 4:28am 30 April 2023 - 🇺🇸United States smustgrave
Wonder if the IS could be updated if a solution.
Tried testing the patch and if the solution to add a link to the Structure page I did not see the link. Cleared cache several times
And when toolbar module is enabled I'm not seeing Announcements twice in the toolbar. Think that could be confusing.
- last update
over 1 year ago 29,372 pass - last update
over 1 year ago 29,349 pass, 2 fail - last update
over 1 year ago 29,372 pass - Status changed to Needs review
over 1 year ago 11:14am 2 May 2023 - 🇪🇸Spain fjgarlin
I updated the IS with the solution that this MR provides.
Tried testing the patch and if the solution is to add a link to the Structure page I did not see the link. Cleared cache several times
It was never under the "Structure" page, it was, and it still is, under the "/admin" page. I tried to think about arguments to add it inside the "Content", "Structure" or "Configuration" menu, but this is none of those really, so a link under the "Administration" page seems appropriate.
And when toolbar module is enabled I'm now seeing Announcements twice in the toolbar. Think that could be confusing.
That has been addressed now. It's shown only once.
--
With this MR, the help text provides a link to access the announcements page directly and it also shows a link under the "/admin" and "/admin/index" pages to access the announcements.
- 🇮🇳India varun verma
I have review that, when toolbar module is enabled then Announcements showing once only. screenshot attached for reference.
- Status changed to RTBC
over 1 year ago 1:29pm 3 May 2023 - 🇺🇸United States smustgrave
Thanks for the issue summary update.
Tested again when the toolbar module is disabled the link does appear under
/admin technically it appears with or without the toolbar module I should say. - last update
over 1 year ago 29,375 pass - last update
over 1 year ago 29,379 pass - last update
over 1 year ago 29,380 pass - last update
over 1 year ago 29,381 pass - last update
over 1 year ago 29,384 pass - last update
over 1 year ago 29,389 pass - last update
over 1 year ago 29,388 pass, 2 fail - last update
over 1 year ago 29,389 pass - last update
over 1 year ago 29,389 pass - last update
over 1 year ago 29,389 pass - last update
over 1 year ago 29,389 pass - last update
over 1 year ago 29,396 pass - last update
over 1 year ago 29,400 pass - last update
over 1 year ago 29,400 pass 14:22 7:20 Running- last update
over 1 year ago 29,410 pass - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - last update
over 1 year ago 29,419 pass - last update
over 1 year ago 29,421 pass - last update
over 1 year ago 29,421 pass - last update
over 1 year ago 29,426 pass - last update
over 1 year ago 29,430 pass -
longwave →
committed 611cda61 on 10.1.x
Issue #3356515 by fjgarlin, varun verma, smustgrave: Give users a way to...
-
longwave →
committed 611cda61 on 10.1.x
- Status changed to Fixed
over 1 year ago 12:55pm 16 June 2023 -
longwave →
committed 8b92bea8 on 11.x
Issue #3356515 by fjgarlin, varun verma, smustgrave: Give users a way to...
-
longwave →
committed 8b92bea8 on 11.x
- 🇬🇧United Kingdom longwave UK
Discussed with @lauriii and @catch, given that this makes the new module more usable without toolbar being installed we agreed to backport to 10.1.x.
Committed and pushed 8b92bea8c7 to 11.x (10.2.x) and 611cda6107 to 10.1.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.