Rename $op to $operation arguments

Remaining ones are in controllers and tests

Don't mind marking this but it's going to need a reroll if the first ticket gets in. So probably should be postponed.

Needs a reroll, unsure why TestBot didn't kick this back to NR.

re-roll, context changes in user.module

Rerolls on RTBC issues can go straight back to RTBC.

Needs another re-roll.

Reroll

+1 RTBC as node parts fixed in 📌 Rename $op operation in hook_node_grants[_alter]() and node_access_grants to $operation Fixed

Still lots of $op arguments, at least some of these are considered API?

Regex for this search was function.*\$op\W.

composer/Plugin/Scaffold/ScaffoldFileInfo.php:  public function __construct(ScaffoldFilePath $destination, OperationInterface $op) {
core/lib/Drupal/Core/Config/ConfigImporterEvent.php:  public function getChangelist($op = NULL, $collection = StorageInterface::DEFAULT_COLLECTION) {
core/lib/Drupal/Core/Config/ConfigImporter.php:  protected function checkOp($collection, $op, $name) {
core/lib/Drupal/Core/Config/ConfigImporter.php:  protected function importConfig($collection, $op, $name) {
core/lib/Drupal/Core/Config/ConfigImporter.php:  protected function importInvokeOwner($collection, $op, $name) {
core/lib/Drupal/Core/Config/ConfigImporter.php:  protected function processConfiguration($collection, $op, $name) {
core/lib/Drupal/Core/Config/ConfigImporter.php:  protected function processExtension($type, $op, $name) {
core/lib/Drupal/Core/Config/ConfigImporter.php:  protected function setProcessedConfiguration($collection, $op, $name) {
core/lib/Drupal/Core/Config/ConfigImporter.php:  protected function setProcessedExtension($type, $op, $name) {
core/lib/Drupal/Core/Config/ConfigImporter.php:  public function getExtensionChangelist($type, $op = NULL) {
core/lib/Drupal/Core/Config/StorageComparerInterface.php:  public function getChangelist($op = NULL, $collection = StorageInterface::DEFAULT_COLLECTION);
core/lib/Drupal/Core/Config/StorageComparer.php:  protected function addChangeList($collection, $op, array $changes, array $sort_order = NULL) {
core/lib/Drupal/Core/Config/StorageComparer.php:  protected function removeFromChangelist($collection, $op, $name) {
core/lib/Drupal/Core/Config/StorageComparer.php:  public function getChangelist($op = NULL, $collection = StorageInterface::DEFAULT_COLLECTION) {
core/modules/block/src/Controller/BlockController.php:  public function performOperation(BlockInterface $block, $op) {
core/modules/file/tests/file_test/file_test.module:function file_test_get_calls($op) {
core/modules/file/tests/file_test/file_test.module:function _file_test_get_return($op) {
core/modules/file/tests/file_test/file_test.module:function _file_test_log_call($op, $args) {
core/modules/file/tests/file_test/file_test.module:function file_test_set_return($op, $value) {
core/modules/search/src/Controller/SearchController.php:  public function performOperation(SearchPageInterface $search_page, $op) {
core/modules/system/src/Controller/DbUpdateController.php:  public function handle($op, Request $request) {
core/modules/system/tests/modules/image_test/src/Plugin/ImageToolkit/TestToolkit.php:  protected function logCall($op, $args) {
core/modules/system/tests/src/Functional/Entity/Traits/EntityDefinitionTestTrait.php:  protected function doEntityUpdate($op, $entity_type_id) {
core/modules/system/tests/src/Functional/Entity/Traits/EntityDefinitionTestTrait.php:  protected function doFieldUpdate($op, $storage_definition = NULL, $original_storage_definition = NULL) {
core/modules/user/tests/src/Kernel/UserMailNotifyTest.php:  public function testUserMailsNotSent($op) {
core/modules/user/tests/src/Kernel/UserMailNotifyTest.php:  public function testUserMailsSent($op, array $mail_keys) {
core/modules/views_ui/src/Controller/ViewsUIController.php:  public function ajaxOperation(ViewEntityInterface $view, $op, Request $request) {
core/tests/Drupal/Tests/Core/Access/AccessResultTest.php:  public function testAndOrCacheabilityPropagation(AccessResultInterface $first, $op, AccessResultInterface $second, $implements_cacheable_dependency_interface, $is_cacheable) {

For #12

I will provide a patch soon

Please review this patch. Replaced $op with $operation as per #12. I excluded controllers to replace $op with $operation.

Thanks

tests are failling

How come the change to ScaffoldFileInfo.php was reverted?

Hi I rename the $op arguments in ScaffoldFileInfo.php to $operation, please revise

Using the regex from #12 there are still some instances but just a few

\Drupal\Core\Update\UpdateKernel::setupRequestMatch() requires to use $op so I reverted it - needs separate issue to deprecate it properly - 📌 Rename $op with BC usage in update.php Active

There's few hunks needs to be moved to separate issues

- local variables - to prevent mix with arguments
- routing - needs to provide BC for routing arguments