- Issue created by @andypost
- First commit to issue fork.
- Assigned to ankitsingh0188
- Merge request !8870Issue #3380781 by ankitsingh0188: Rename with BC usage in update.php โ (Open) created by ankitsingh0188
- Issue was unassigned.
- Status changed to Needs review
5 months ago 6:29am 22 July 2024 - Status changed to Needs work
5 months ago 2:26pm 22 July 2024 - ๐บ๐ธUnited States smustgrave
find a way to throw deprecation message when $op is send
Doesn't appear to be addressed
- Status changed to Needs review
5 months ago 6:05am 23 July 2024 - ๐ฎ๐ณIndia ankitsingh0188 Pune
@smustgrave - Please review my latest commit and let me know if there's anything else needs to be updated.
- Status changed to Needs work
5 months ago 6:47am 23 July 2024 The Needs Review Queue Bot โ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- Status changed to Needs review
5 months ago 7:25am 23 July 2024 - Status changed to Needs work
5 months ago 11:55am 23 July 2024 - ๐บ๐ธUnited States smustgrave
Think this should have a simple test for verifying the deprecation is triggered
- ๐ฎ๐ณIndia ankitsingh0188 Pune
@smustgrave - I think there's no tests earlier for this file. Do we really need a test for this. Please suggest.
- Status changed to Needs review
5 months ago 5:10am 9 August 2024 - ๐บ๐ธUnited States smustgrave
Still think a test would be good, so will leave for the next reviewer.
- ๐บ๐ธUnited States smustgrave
So seems no one picked up after a month. Still maintain test coverage should be there has this seem like a unique deprecation.
The Needs Review Queue Bot โ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- ๐ฎ๐ณIndia ankitsingh0188 Pune
Not sure the test is required. Let's leave it for the next reviewer.
- ๐บ๐ธUnited States smustgrave
Well this issue has sat for almost 2 months but I donโt plan to mark without test coverage.
We add test coverage for other deprecations not sure how this should be exempt