🇮🇳India @ankitsingh0188

The $value type can be array or string or bool most of the times it would be array but we are not sure if the type is bool then in that we need to change it to array|string|bool

IMO, we can use mixed return type instead of specifying the each return type individually.

ankitsingh0188 → changed the visibility of the branch 3414535-wrong-type-in to hidden.

ankitsingh0188 → made their first commit to this issue’s fork.

@smustgrave We are not sure whether it'll be array or string or int or bool.

The mixed type accepts every value. It is equivalent to the union type object|resource|array|string|float|int|bool|null.

ankitsingh0188 → made their first commit to this issue’s fork.

@smustgrave - Please review

git checkout -b '11.x' --track drupal-3414535/'11.x'

The above commands not working because 11.x branch was already exists while taking the clone from drupal.git

Conflicts resolved, please review the MR!

ankitsingh0188 → changed the visibility of the branch 11.x to active.

ankitsingh0188 → changed the visibility of the branch 11.x to hidden.

ankitsingh0188 → created an issue.

I contributed to DrupalCamp Pune 2024 and handled the responsibility of Photography #dcp2024

Not sure the test is required. Let's leave it for the next reviewer.

Please review the child issue https://www.drupal.org/project/drupal/issues/3380781 📌 Rename $op with BC usage in update.php Active

@smustgrave - I think there's no tests earlier for this file. Do we really need a test for this. Please suggest.

@smustgrave - Please review my latest commit and let me know if there's anything else needs to be updated.

ankitsingh0188 → made their first commit to this issue’s fork.

Berdir → credited ankitsingh0188 → .

There's already a code in "hook_user_login" which will validate if there's a destination query param and it's value should not be '/user/login' then will skip the redirection.

/**
 * Implements hook_user_login().
 */
function redirect_after_login_user_login($account) {
  $current_route = Drupal::routeMatch()->getRouteName();
  $request = Drupal::request();
  if ($request->getRequestFormat() !== 'html') {
    return;
  }
  $destination = $request->query->get('destination');
  if ($destination && $destination != '/user/login') {
    return;
  }

I've updated the patch with the new CR.

@jungle I have updated the patch and using IoC wherever possible.

I think the patch #25 📌 Replace non-test usages of \Drupal::languageManager() with IoC injection Needs review will address the issue as mentioned in #21 📌 Replace non-test usages of \Drupal::languageManager() with IoC injection Needs review

I have updated the patch as per #34 📌 Move methods from TourTipPluginInterface and deprecate this interface. Fixed .

What if we get the DatabaseException ?

In that case $e->getMessage() will not work as mentioned Steps to reproducesection.

I think the exception interface should extend the \Throwable with respect to what you're catching is something that is a \Throwable.

I've created the patch with the new CR.

Hi @murilohp

it's better if you add the interdiff between #24 & #29.

@smustgrave Still needs a change record, which would then need to be added to the patch. -> Please help me with this I have added the tests and refactor the whole interface also, if there's anything else missing please let me know.

@smustgrave what changes exactly can you please elaborate?

Interdiff is same as mentioned in #22

Good to move to RTBC.

All the patches are same only the difference of the file path as patch was failed to apply earlier. I have included the interdiff in #10

Additionally the patches are failing in #11 but I ran the retest again and it successfully passed.

If you see the error you’ll get to know due to date mismatch test failed just because after 12 midnight day changes.

Patch #24 🐛 Notice: Undefined index: type in Drupal\Core\Render\Element\Date::processDate() Closed: outdated applied successfully. I have tested the patch and it works for me.

I have attached the screenshot before_patch.png in which I am getting the notice and it disappears after I applied the patch.

Looks good to me! Good to move it to RTBC.