Make DatabaseException extend \Throwable

I've created the patch with the new CR.

Maybe \Throwable is too high in the inheritance tree? In the end aren't we facing a kind of \RuntimeException when the database fails?

What if we get the DatabaseException ?

In that case $e->getMessage() will not work as mentioned Steps to reproducesection.

I think the exception interface should extend the \Throwable with respect to what you're catching is something that is a \Throwable.

Not every implementer of DatabaseException extends RuntimeException, though. See InvalidQueryException.

class InvalidQueryException extends \InvalidArgumentException implements DatabaseException {}

The proposed patch is guaranteed to work with existing code, and I think it's the best solution.

Overall I feel like this shouldn't be necessary, however to make it unnecessary I think we'd have to change the database API's InvalidArgumentExceptions to assertions. Also discussed briefly with @longwave who pointed out that Guzzle has the same pattern.

So.. Committed 87d90f9 and pushed to 10.1.x. Thanks!

catch → credited longwave → .

Automatically closed - issue fixed for 2 weeks with no activity.

Published the CR.