- Issue created by @jan kellermann
- 🇩🇪Germany jan kellermann
Maybe just a beginning. Please add your comments and feedback.
- 🇬🇧United Kingdom MrDaleSmith
There are failing tests that need to be addressed, and I don't think you need to comment out code in an example module - it shouldn't be used in any case so it won't break anything if you just add the code.
- First commit to issue fork.
- First commit to issue fork.
- Status changed to Needs work
about 2 months ago 12:31pm 26 March 2025 - First commit to issue fork.
- First commit to issue fork.
- 🇮🇳India shalini_jha
I reviewed the pipeline failure and found that it was caused by the cspell issue and same checked for MR feedback ✨ Missing documentation for loadModelsForm() Active , and now the pipeline failure is fixed after following the feedback. Moving this NR for further feedback.
- 🇬🇧United Kingdom MrDaleSmith
I still don't see why an example module that cannot be used has code in it that is commented out.
- 🇩🇪Germany jan kellermann
> I still don't see why an example module that cannot be used has code in it that is commented out.
I feel it's the right thing to do, because settings per model are certainly the exception.
Can't RTBC, because most of the patch is mine.