[meta] Determine impact of [#3350972] fix in off-canvas.js on currently disabled FunctionalJavascript tests

Created on 9 April 2023, almost 2 years ago
Updated 25 April 2023, over 1 year ago

Problem/Motivation

In πŸ› [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections() Fixed @nod_ introduced a "fix" for problems with the correct opening of an off-canvas dialog which potentially could fix all JS random test failures for tests using the library drupal.dialog.off_canvas somehow.

This issue is a META to track-n-test all currently skipped FunctionalJavascript tests that make use of that library.

The basic test for each issue would be:

  1. Unskip test.
  2. Run _only_ now unskipped test a lot of times () as-is.
  3. Run _only_ now unskipped test a lot of times () _without_ the changes in πŸ› [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections() Fixed .
  4. If 2, passes and 3 doesn't, we can safely turn the test back on again.

Per @xjm in #3353085-4: [meta] Determine impact of [#3350972] fix in off-canvas.js on currently disabled FunctionalJavascript tests β†’ we now need to go for a 5000-8000 times run for both patches.

Currently the library drupal.dialog.off_canvas is used in:

- core/modules/layout_builder/layout_builder.libraries.yml, so we need to check all skipped tests in core/modules/layout_builder/tests/src/FunctionalJavascript.
- core/themes/stable9/stable9.info.yml, so we need to check all skipped FunctionalJavascript tests that use that theme.
- Just went through every skipped FunctionalJavascript test.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Fixed

Version

10.0 ✨

Component
BaseΒ  β†’

Last updated about 4 hours ago

Created by

πŸ‡³πŸ‡±Netherlands spokje

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024