- Issue created by @spokje
- Status changed to Needs review
over 1 year ago 2:33pm 9 April 2023 - π³π±Netherlands spokje
Test seems too slow for 1500x, let's try 1000x.
- Status changed to Active
over 1 year ago 5:19pm 9 April 2023 - Status changed to Needs review
over 1 year ago 8:18pm 9 April 2023 - π³π±Netherlands spokje
So basically
\Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderDisableInteractionsTest::assertContextualLinksClickable
is currently completely broken on Drupal CI.Locally the should_fail test passes, which indeed points to a timing issue, solved by π [random test failure] Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderUiTest::testReloadWithNoSections() Fixed .
- π³π±Netherlands spokje
Both patches in #6 π [no random test failure] Try to un-skip and fix LayoutBuilderDisableInteractionsTest::assertContextualLinksClickable in context of [#3353085] Fixed need to be requeue-ed multiple times until they have both run between 5000-8000 times before this can be reviewed. (See @xjm in #3353085-4: [meta] Determine impact of [#3350972] fix in off-canvas.js on currently disabled FunctionalJavascript tests β )
- Status changed to Needs work
over 1 year ago 10:31am 10 April 2023 - π³π±Netherlands spokje
To be clear: I won't be re-queueing patches on this one, so feel free to step in and re-queue away
- Status changed to Needs review
over 1 year ago 3:52pm 10 April 2023 - πΊπΈUnited States xjm
I queued the jobs. Not sure what the issue is; all you have to do is check "Custom parameters", click queue, hit the back button, and repeat.
- π³π±Netherlands spokje
all you have to do is check "Custom parameters", click queue, hit the back button, and repeat.
TIL... Never used nor imagined that Custom runs _can_ be queued in advance where the "normal" ones can't.
- Status changed to RTBC
over 1 year ago 1:51pm 12 April 2023 - πΊπΈUnited States smustgrave
Based on the green and red I think the condition of the issue summary has been met haha.
- Status changed to Fixed
over 1 year ago 9:09am 24 April 2023 - π¬π§United Kingdom catch
Cherry-picked to 10.0.x, and 9.5.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.