- Issue created by @idiaz.roncero
- Assigned to royalpinto007
- @royalpinto007 opened merge request.
- Status changed to Needs review
over 1 year ago 7:33pm 14 February 2023 - 🇮🇳India royalpinto007
I updated the margin values of .form-actions .action-link to match the 0.5rem margin used for .dropbutton-wrapper in the Claro theme's dropbutton.css file. This will ensure that the margins are consistent across both types of buttons.
We can even think of updating the margin values of the .dropbutton-wrapper CSS to match the 1rem margin used for .form-actions .action-link in the Claro theme's form.css file.
- 🇮🇳India nayana_mvr
Verified the MR!3470 and tested it on Drupal version 9.5.x. The patch works fine and I have added the before and after screenshots for reference.
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 3:46pm 22 February 2023 - 🇮🇳India rckstr_rohan
Verified the merge request on #3, issue has been fixed.
- 🇮🇳India nayana_mvr
Verified the patch #9 and tested it on Drupal version 10.1.x. The patch works fine and I can confirm that the issue is resolved in Drupal 10 version also. Screenshots are same as in #5.
- Status changed to Needs work
over 1 year ago 6:07pm 24 February 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 6:30pm 24 February 2023 - Status changed to RTBC
over 1 year ago 8:27pm 24 February 2023 The last submitted patch, 9: 3341669-9-10.1.x.patch, failed testing. View results →
- Status changed to Needs work
over 1 year ago 7:49am 27 April 2023 - 🇮🇳India athyamvidyasagar
I have created this patch for 10.1.x-dev and its working as expected. Please verify
- last update
over 1 year ago 29,359 pass - 🇮🇳India Nishant
Applied #18 patch on Drupal 10.1.x-dev with Claro theme and It's working fine.
- 🇦🇺Australia thomwilhelm Sydney
Supplying a 9.5.x version of the patch for anyone upgrading to Claro before the Drupal 10 upgrade.
- First commit to issue fork.
- @jennakoo opened merge request.
- 🇫🇮Finland jennakoo
Copied the fixing lines from MR!3470 of #3 and reapplied on Drupal 11.x.
- Status changed to Needs review
about 1 year ago 1:58pm 10 November 2023 - Status changed to RTBC
about 1 year ago 2:53pm 10 November 2023 Reviewed the code and tested the latest patch against 11.x, text is now aligned.
- last update
about 1 year ago 29,682 pass - Status changed to Needs work
about 1 year ago 3:01pm 10 November 2023 - 🇫🇮Finland lauriii Finland
Nice work here! I posted a minor comment on the MR regarding duplicate properties.
- Status changed to Needs review
about 1 year ago 3:56pm 10 November 2023 - Status changed to RTBC
about 1 year ago 4:26pm 10 November 2023 - 🇫🇮Finland Laurie Lim Helsinki
Tested change and reviewed code, duplicate margin property removed.
- Status changed to Fixed
about 1 year ago 4:45pm 10 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.