Fix the issues reported by phpcs

Fixing the phpcs warnings, attaching the patch, please review.

Charchil Khandelwal → made their first commit to this issue’s fork.

I will review this.

Patch #2 tested and applied successfully, all the errors and warnings are fixed.
Created MR !4 for easy preview and commenting.
RTBC +1.

Thanks.

Hi Charchil Khandelwal

I reviewed MR!4, and verified it fixes all the issue reported by phpcs. Drupal core version 9.5.8, Bootstrap Paragraphs 8.x-2.x-dev.

I added screenshots for reference.
Thank You.

-  - paragraphs
-  - bootstrap_paragraphs
+  - drupal:paragraphs
+  - drupal:bootstrap_paragraphs

Those are not Drupal core modules.

Providing patch with solution.
please review.

-  - paragraphs
-  - bootstrap_paragraphs
+  - paragraphs: paragraphs
+  - bootstrap_paragraphs: bootstrap_paragraphs

The space after the colon must be removed.

paraderojether → closed merge request !7

-  - paragraphs
-  - bootstrap_paragraphs
+  - drupal:paragraphs
+  - drupal:bootstrap_paragraphs

Those are not Drupal core modules.

-  - paragraphs
-  - bootstrap_paragraphs
+  - drupal:paragraphs
+  - drupal:bootstrap_paragraphs

If those are not Drupal core modules, drupal: cannot be used to refer to those modules. The dependencies format is [project name]:[module name], where [project name] is replaced by the machine name of the project that contains the module, and [module name] is the module machine name.

Working on this for Drupalcon 2023 Pittsburgh

Please check MR.
Hide patch files, let's continue with MR workflow.

Hi @everyone,

Applied and reviewed MR!4, on my terminal, errors were still reported. Please see below:

bootstrap_paragraphs git:(8.x-2.x) curl https://git.drupalcode.org/project/bootstrap_paragraphs/-/merge_requests/4.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2446    0  2446    0     0   6360      0 --:--:-- --:--:-- --:--:--  6575
patching file README.md
patching file modules/bp_callout/bp_callout.info.yml
patching file modules/bp_quicklinks/README.md
patching file modules/bp_statistics/bp_statistics.info.yml
➜  bootstrap_paragraphs git:(8.x-2.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig bootstrap_paragraphs

FILE: ...drupal-orgissue-v9/web/modules/contrib/bootstrap_paragraphs/CONTRIBUTOR.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 166 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------------


FILE: ...phs/config/optional/field.storage.paragraph.bp_link_open_in_new_window.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 17 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...e-v9/web/modules/contrib/bootstrap_paragraphs/bootstrap_paragraphs.install
--------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------
  10 | ERROR | [x] Use statements should be sorted alphabetically. The first
     |       |     wrong one is Drupal\Component\Utility\NestedArray.
 392 | ERROR | [x] Expected 1 blank line after function; 3 found
 395 | ERROR | [ ] More than 2 empty lines are not allowed
 421 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 421 | ERROR | [x] Line indented incorrectly; expected at least 2 spaces, found
     |       |     1
 421 | ERROR | [x] Array indentation error, expected 4 spaces but found 1
 441 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 441 | ERROR | [x] Line indented incorrectly; expected at least 2 spaces, found
     |       |     1
 441 | ERROR | [x] Array indentation error, expected 4 spaces but found 1
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 617ms; Memory: 14MB

Kindly check

Thanks,
Jake

Merged to dev, thanks all.

Automatically closed - issue fixed for 2 weeks with no activity.