- Issue created by @sahil.goyal
- ๐ฎ๐ณIndia sahil.goyal
Fixing the phpcs warnings, attaching the patch, please review.
- Status changed to Needs review
over 1 year ago 3:23am 6 February 2023 - ๐ฎ๐ณIndia Charchil Khandelwal
Charchil Khandelwal โ made their first commit to this issueโs fork.
- Assigned to Charchil Khandelwal
- Merge request !4Issue #3339420: Drupal Coding Standards Issues | phpcs โ (Open) created by Charchil Khandelwal
- ๐ฎ๐ณIndia Charchil Khandelwal
Patch #2 tested and applied successfully, all the errors and warnings are fixed.
Created MR !4 for easy preview and commenting.
RTBC +1.Thanks.
- Issue was unassigned.
- Status changed to RTBC
about 1 year ago 3:26am 2 May 2023 - ๐ต๐ญPhilippines paraderojether
Hi Charchil Khandelwal
I reviewed MR!4, and verified it fixes all the issue reported by phpcs. Drupal core version 9.5.8, Bootstrap Paragraphs 8.x-2.x-dev.
I added screenshots for reference.
Thank You. - Status changed to Needs work
about 1 year ago 9:02am 2 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
- - paragraphs - - bootstrap_paragraphs + - drupal:paragraphs + - drupal:bootstrap_paragraphs
Those are not Drupal core modules.
- Status changed to Needs review
about 1 year ago 9:53am 2 May 2023 - ๐ฎ๐ณIndia Ashutosh Ahirwal India
Providing patch with solution.
please review. - Status changed to Needs work
about 1 year ago 11:36am 2 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
- - paragraphs - - bootstrap_paragraphs + - paragraphs: paragraphs + - bootstrap_paragraphs: bootstrap_paragraphs
The space after the colon must be removed.
- @paraderojether opened merge request.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
- - paragraphs - - bootstrap_paragraphs + - drupal:paragraphs + - drupal:bootstrap_paragraphs
Those are not Drupal core modules.
- Status changed to Needs review
about 1 year ago 1:14am 4 May 2023 - Status changed to Needs work
about 1 year ago 7:51am 4 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
- - paragraphs - - bootstrap_paragraphs + - drupal:paragraphs + - drupal:bootstrap_paragraphs
If those are not Drupal core modules,
drupal:
cannot be used to refer to those modules. The dependencies format is [project name]:[module name], where [project name] is replaced by the machine name of the project that contains the module, and [module name] is the module machine name. - ๐บ๐ธUnited States Devon_4224
Working on this for Drupalcon 2023 Pittsburgh
- Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 1:04pm 9 June 2023 - Status changed to Needs work
5 months ago 11:12pm 21 January 2024 - ๐ท๐บRussia zniki.ru
Please check MR.
Hide patch files, let's continue with MR workflow. - Status changed to Needs review
5 months ago 8:17am 22 January 2024