- Assigned to royalpinto007
- Status changed to Needs work
almost 2 years ago 9:04am 13 February 2023 - @royalpinto007 opened merge request.
- Status changed to Needs review
almost 2 years ago 6:45pm 13 February 2023 - 🇮🇳India royalpinto007
I've built the file and ran some local tests, and it looks like everything is working as expected. No errors were encountered during testing.
This refactor has been a long time coming, and I'm glad we finally got around to making these changes.
The system-admin panel is a critical component of Claro, and it's important that it looks and works its best.
I hope these changes make the experience for our users smoother and more enjoyable.If you have any questions or concerns about these changes, please let me know.
Thanks!
- Status changed to Needs work
almost 2 years ago 7:10pm 13 February 2023 The issue summary says:
None. There should be no visual differences.
Please post before/after screenshots and make sure they look the same.- 🇮🇳India gauravvvv Delhi, India
Before patch:
After patch #4:
Some selectors are changed, which needs to fixed. moving to NW.
- Status changed to Needs review
almost 2 years ago 6:11am 14 February 2023 - 🇮🇳India gauravvvv Delhi, India
I have corrected the selectors and improved the nesting. Updated MR for same. Please review
After patch:
- Issue was unassigned.
- Status changed to RTBC
almost 2 years ago 6:02pm 22 February 2023 - 🇺🇸United States smustgrave
Nesting looks good
Variables are being used
before/after screenshots added. - Status changed to Needs review
over 1 year ago 12:16pm 7 April 2023 - 🇫🇷France nod_ Lille
The specificity of the selector is changed by the patch and it's not clear that this is necessary, if there are no other changes or justification that'd be a won't fix for me.
- 🇮🇳India gauravvvv Delhi, India
The specificity of the selector is changed (increased) by the patch
Specificity is updated just to improve nesting.
- 🇫🇷France nod_ Lille
right, but that can cause issues with projects that override just a few things.
My understanding is that we'd use nesting if that simplify generating the same output as before. In this case the code before refactoring didn't use selectors that could be simplified with nesting, so nesting shouldn't be necessary.
- Status changed to Needs work
over 1 year ago 1:03pm 7 April 2023 - Status changed to Closed: works as designed
over 1 year ago 1:12pm 7 April 2023 - 🇫🇷France nod_ Lille
Thanks, since this is the only change in this MR, I'm closing as works a designed.
See you in the other CSS issues :)
- Status changed to Needs work
over 1 year ago 1:14pm 7 April 2023 - 🇫🇷France nod_ Lille
Actually we could use some logical properties in this file. Not that we have a need for RTL styles but it can't hurt :)
- Status changed to Needs review
over 1 year ago 4:04am 10 April 2023 - 🇮🇳India gauravvvv Delhi, India
Updated MR with logical properties and removed the increased selector specificity. please review
- Assigned to Guru2023
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 6:21pm 11 April 2023 - Status changed to Fixed
over 1 year ago 7:44pm 25 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.