- Status changed to Needs review
over 1 year ago 6:05am 27 February 2023 - Status changed to Needs work
over 1 year ago 6:09pm 28 February 2023 - 🇺🇸United States smustgrave
.messages a { text-decoration: underline; color: var(--messages__link-color); } .messages a:hover { color: var(--messages__link--hover-color); } .messages pre { margin: 0; }
think more nesting could be done here.
- Status changed to Needs review
over 1 year ago 6:33am 1 March 2023 - 🇮🇳India gauravvvv Delhi, India
Addressed #8, make few more changes. Attached patch, interdiff and after patch screenshot. please review
After patch
- Status changed to RTBC
over 1 year ago 8:58pm 1 March 2023 - Status changed to Needs work
over 1 year ago 8:44am 4 March 2023 - 🇫🇮Finland lauriii Finland
+++ b/core/themes/claro/css/components/messages.pcss.css @@ -65,63 +75,37 @@ + @nest .messages--error & { ... + @nest .messages--status & { ... + @nest .messages--warning & { ... + @nest [dir="rtl"] & {
This would probably be easier to read if we combined these with the similar selectors few lines above to something like this:
.messages--error { .messages__header { } }
- Status changed to Needs review
over 1 year ago 3:58am 13 March 2023 - 🇮🇳India gauravvvv Delhi, India
Addressed #11, attached patch and interdiff for same. please review
- Status changed to RTBC
over 1 year ago 4:29pm 13 March 2023 - 🇺🇸United States smustgrave
Here's a few screenshots but appears everything is still functional
The last submitted patch, 12: 3332419-12.patch, failed testing. View results →
- Status changed to Fixed
over 1 year ago 3:04am 27 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.